fix: Added the web3_clientVersion to the websocket server. #2486

ebadiere · 2024-05-13T19:04:33Z

Added the web3_clientVersion to the websocket server.

Fixes #2462

Signed-off-by: ebadiere <[email protected]>

github-actions · 2024-05-13T19:09:10Z

Tests

    2 files 147 suites 13s ⏱️
819 tests 818 ✔️ 1 💤 0 ❌
831 runs 830 ✔️ 1 💤 0 ❌

Results for commit cd95d51.

♻️ This comment has been updated with latest results.

quiet-node

It's necessary to add WEB3_CLIENTVERSION: 'web3_clientVersion' in WS_CONSTANTS.METHODS or else the server will return Method web3_clientVersion not found

AlfredoG87

Can we add an acceptance test aswell?

github-actions · 2024-05-13T19:26:20Z

Acceptance Tests

    32 files   411 suites 55m 51s ⏱️
  584 tests   573 ✔️   3 💤   8 ❌
1 900 runs 1 866 ✔️ 11 💤 23 ❌

Results for commit cd95d51.

♻️ This comment has been updated with latest results.

Signed-off-by: ebadiere <[email protected]>

packages/ws-server/tests/acceptance/web3ClientVersion.spec.ts

Signed-off-by: ebadiere <[email protected]>

quiet-node

LGTM

Nana-EC

LG.
Execution pathway logic should be improved

packages/ws-server/src/controllers/index.ts

Signed-off-by: ebadiere <[email protected]>

AlfredoG87

one question, otherwise looks good

AlfredoG87 · 2024-05-14T01:53:35Z

packages/ws-server/src/controllers/index.ts

+      case 'eth':
+        txRes = await relay.eth()[methodName](...resolvedParams, requestIdPrefix);
+        break;
+      case 'get':


are we supporting any get or debug pathways yet?

@Nana-EC asked that the pathways be specific, in the above comments.

quiet-node

a simple improvement

quiet-node · 2024-05-14T16:57:43Z

packages/ws-server/src/controllers/index.ts

-    const txRes = await relay.eth()[method.split('_')[1]](...resolvedParams, requestIdPrefix);
+    const [service, methodName] = method.split('_');
+    let txRes;
+    switch (service) {


I think there's a possible replacement for this whole switch statement is this below:

Suggested change

switch (service) {

const txRes = await relay[service]()[methodName](...resolvedParams, requestIdPrefix);

And we don't have to worry about throwing new Error(Unsupported JSON RPC service type: ${service}); as there's already an unsupported method check (verifySupportedMethod()) to check validity of the methods before it gets to this step.

Signed-off-by: ebadiere <[email protected]>

AlfredoG87

LGTM

Nana-EC

LG
An extra comment would be good

packages/ws-server/src/controllers/index.ts

Signed-off-by: ebadiere <[email protected]>

sonarqubecloud · 2024-05-15T18:27:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

* fix: Added the web3_clientVersion to the websocket server. Signed-off-by: ebadiere <[email protected]> * fix: Updated web3_clientVersion and test. Signed-off-by: ebadiere <[email protected]> * fix: Removed only. Signed-off-by: ebadiere <[email protected]> * fix: applied feedback Signed-off-by: ebadiere <[email protected]> * fix: Added addition service method handling paths. Signed-off-by: ebadiere <[email protected]> * fix: Reduced the switch statement to one line. Signed-off-by: ebadiere <[email protected]> * fix: Added comment describing JSON RPC validation method. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]>

* fix: Added the web3_clientVersion to the websocket server. Signed-off-by: ebadiere <[email protected]> * fix: Updated web3_clientVersion and test. Signed-off-by: ebadiere <[email protected]> * fix: Removed only. Signed-off-by: ebadiere <[email protected]> * fix: applied feedback Signed-off-by: ebadiere <[email protected]> * fix: Added addition service method handling paths. Signed-off-by: ebadiere <[email protected]> * fix: Reduced the switch statement to one line. Signed-off-by: ebadiere <[email protected]> * fix: Added comment describing JSON RPC validation method. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Alfredo Gutierrez <[email protected]>

fix: Added the web3_clientVersion to the websocket server. (#2486) * fix: Added the web3_clientVersion to the websocket server. * fix: Updated web3_clientVersion and test. * fix: Removed only. * fix: applied feedback * fix: Added addition service method handling paths. * fix: Reduced the switch statement to one line. * fix: Added comment describing JSON RPC validation method. --------- Signed-off-by: ebadiere <[email protected]> Signed-off-by: Alfredo Gutierrez <[email protected]> Co-authored-by: Eric Badiere <[email protected]>

fix: Added the web3_clientVersion to the websocket server.

bd96afa

Signed-off-by: ebadiere <[email protected]>

ebadiere added the bug Something isn't working label May 13, 2024

ebadiere self-assigned this May 13, 2024

ebadiere requested review from AlfredoG87, georgi-l95, Ivo-Yankov and a team as code owners May 13, 2024 19:04

ebadiere mentioned this pull request May 13, 2024

fix: Added web3_clientVersion to the websocker server and fixed typos. #2485

Closed

quiet-node requested changes May 13, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

AlfredoG87 requested changes May 13, 2024

View reviewed changes

fix: Updated web3_clientVersion and test.

3d85824

Signed-off-by: ebadiere <[email protected]>

quiet-node requested changes May 13, 2024

View reviewed changes

packages/ws-server/tests/acceptance/web3ClientVersion.spec.ts Outdated Show resolved Hide resolved

packages/ws-server/tests/acceptance/web3ClientVersion.spec.ts Outdated Show resolved Hide resolved

packages/ws-server/tests/acceptance/web3ClientVersion.spec.ts Show resolved Hide resolved

ebadiere added 2 commits May 13, 2024 14:41

fix: Removed only.

64244d0

Signed-off-by: ebadiere <[email protected]>

fix: applied feedback

fba5636

Signed-off-by: ebadiere <[email protected]>

quiet-node previously approved these changes May 13, 2024

View reviewed changes

Nana-EC requested changes May 13, 2024

View reviewed changes

packages/ws-server/src/controllers/index.ts Outdated Show resolved Hide resolved

fix: Added addition service method handling paths.

707e20f

Signed-off-by: ebadiere <[email protected]>

ebadiere dismissed quiet-node’s stale review via 707e20f May 14, 2024 00:52

AlfredoG87 previously approved these changes May 14, 2024

View reviewed changes

quiet-node requested changes May 14, 2024

View reviewed changes

fix: Reduced the switch statement to one line.

657a7c1

Signed-off-by: ebadiere <[email protected]>

ebadiere dismissed AlfredoG87’s stale review via 657a7c1 May 15, 2024 13:55

quiet-node previously approved these changes May 15, 2024

View reviewed changes

AlfredoG87 previously approved these changes May 15, 2024

View reviewed changes

Nana-EC previously approved these changes May 15, 2024

View reviewed changes

packages/ws-server/src/controllers/index.ts Show resolved Hide resolved

fix: Added comment describing JSON RPC validation method.

cd95d51

Signed-off-by: ebadiere <[email protected]>

ebadiere dismissed Nana-EC’s stale review via cd95d51 May 15, 2024 18:26

ebadiere dismissed stale reviews from AlfredoG87 and quiet-node via cd95d51 May 15, 2024 18:26

Nana-EC approved these changes May 15, 2024

View reviewed changes

ebadiere merged commit d3e4508 into main May 15, 2024
33 checks passed

ebadiere deleted the 2462-web3-clientVersion-websocketServer branch May 15, 2024 22:09

AlfredoG87 mentioned this pull request May 20, 2024

chore: Cherry pick 2486 #2508

Merged

2 tasks

quiet-node added enhancement New feature or request and removed bug Something isn't working labels May 23, 2024

quiet-node added this to the 0.48.0 milestone May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Added the web3_clientVersion to the websocket server. #2486

fix: Added the web3_clientVersion to the websocket server. #2486

ebadiere commented May 13, 2024

github-actions bot commented May 13, 2024 •

edited

Loading

quiet-node left a comment

This comment was marked as outdated.

AlfredoG87 left a comment

github-actions bot commented May 13, 2024 •

edited

Loading

quiet-node left a comment

Nana-EC left a comment •

edited

Loading

AlfredoG87 left a comment

AlfredoG87 May 14, 2024

ebadiere May 14, 2024

quiet-node left a comment

quiet-node May 14, 2024

quiet-node May 14, 2024

ebadiere May 15, 2024

AlfredoG87 left a comment

Nana-EC left a comment

sonarqubecloud bot commented May 15, 2024

	switch (service) {
	const txRes = await relay[service]()[methodName](...resolvedParams, requestIdPrefix);

fix: Added the web3_clientVersion to the websocket server. #2486

fix: Added the web3_clientVersion to the websocket server. #2486

Conversation

ebadiere commented May 13, 2024

github-actions bot commented May 13, 2024 • edited Loading

Tests

quiet-node left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

AlfredoG87 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024 • edited Loading

Acceptance Tests

quiet-node left a comment

Choose a reason for hiding this comment

Nana-EC left a comment • edited Loading

Choose a reason for hiding this comment

AlfredoG87 left a comment

Choose a reason for hiding this comment

AlfredoG87 May 14, 2024

Choose a reason for hiding this comment

ebadiere May 14, 2024

Choose a reason for hiding this comment

quiet-node left a comment

Choose a reason for hiding this comment

quiet-node May 14, 2024

Choose a reason for hiding this comment

quiet-node May 14, 2024

Choose a reason for hiding this comment

ebadiere May 15, 2024

Choose a reason for hiding this comment

AlfredoG87 left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented May 15, 2024

Quality Gate passed

github-actions bot commented May 13, 2024 •

edited

Loading

github-actions bot commented May 13, 2024 •

edited

Loading

Nana-EC left a comment •

edited

Loading