Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-picked #2449 #2450

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: cherry-picked #2449 #2450

merged 1 commit into from
May 6, 2024

Conversation

quiet-node
Copy link
Member

Description:
This PR cherry picked PR#2449 to release 0.47

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…y level (#2449)

* fix: fixed setting WS_NEW_HEADS_ENABLED true as default logic at Relay level

Signed-off-by: Logan Nguyen <[email protected]>

* fix: fixed test

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node added the process Build, test and deployment-process related tasks label May 5, 2024
@quiet-node quiet-node self-assigned this May 5, 2024
Copy link

sonarqubecloud bot commented May 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented May 5, 2024

Tests

    2 files  147 suites   13s ⏱️
819 tests 818 ✔️ 1 💤 0
831 runs  830 ✔️ 1 💤 0

Results for commit ee5a958.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/0.47@8da5fe4). Click here to learn what that means.

❗ Current head 7280068 differs from pull request most recent head ee5a958. Consider uploading reports for the commit ee5a958 to get more accurate results

Files Patch % Lines
packages/relay/src/lib/poller.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.47    #2450   +/-   ##
===============================================
  Coverage                ?   77.27%           
===============================================
  Files                   ?       40           
  Lines                   ?     3225           
  Branches                ?      663           
===============================================
  Hits                    ?     2492           
  Misses                  ?      524           
  Partials                ?      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 5, 2024

Acceptance Tests

  18 files  242 suites   24m 45s ⏱️
586 tests 579 ✔️ 3 💤 4
875 runs  865 ✔️ 5 💤 5

Results for commit ee5a958.

@quiet-node quiet-node merged commit 02d18a9 into release/0.47 May 6, 2024
31 of 32 checks passed
@quiet-node quiet-node deleted the cherry-pick-#2449 branch May 6, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants