Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed debugger settings. #2398

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

ebadiere
Copy link
Contributor

@ebadiere ebadiere commented Apr 23, 2024

Fixes #2397

Allowing "sourceMap": true to be deployed to production can have the following outcomes:

  • Performance impact. Although minimal, it can still result in data being transferred between client and server.
  • More complicated deployment. Managing and deploying source maps is an additional step in the deployment process
  • Cleaner error reporting. When the application uses error reporting tools. Source maps may complicate the logging if they aren't integrated correctly with the tools.

@ebadiere ebadiere added the bug Something isn't working label Apr 23, 2024
@ebadiere ebadiere added this to the 0.47.0 milestone Apr 23, 2024
@ebadiere ebadiere self-assigned this Apr 23, 2024
@ebadiere ebadiere requested review from AlfredoG87, Nana-EC, a team and lukelee-sl as code owners April 23, 2024 20:04
Copy link

github-actions bot commented Apr 23, 2024

Tests

    2 files  147 suites   13s ⏱️
815 tests 814 ✔️ 1 💤 0
827 runs  826 ✔️ 1 💤 0

Results for commit efe8ac6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

Acceptance Tests

     24 files     770 suites   39m 50s ⏱️
   584 tests    576 ✔️ 3 💤   5
3 198 runs  3 171 ✔️ 5 💤 22

Results for commit efe8ac6.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere closed this Apr 24, 2024
@ebadiere ebadiere reopened this Apr 24, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@quiet-node
Copy link
Member

Just for my knowledge why do we need to remove that config? Could you add an explanation in the PR's description to describe more the problem and the outcome so that maybe in the future we need to come back to this there will be an explanation for it?

@ebadiere ebadiere merged commit 49c4699 into main Apr 24, 2024
55 of 57 checks passed
@ebadiere ebadiere deleted the 2397-remove-debugger-settings branch April 24, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove debugger settings in the tsconfig files.
2 participants