Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Websocket documentation updates. #2396

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ebadiere
Copy link
Contributor

Websocket documentation updates.

Related issue(s):

Fixes #2117

@ebadiere ebadiere requested a review from a team as a code owner April 23, 2024 19:58
@ebadiere ebadiere requested a review from quiet-node April 23, 2024 19:58
@ebadiere ebadiere self-assigned this Apr 23, 2024
@ebadiere ebadiere added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation and removed dependencies Pull requests that update a dependency file labels Apr 23, 2024
@ebadiere ebadiere added this to the 0.47.0 milestone Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Tests

    2 files  147 suites   13s ⏱️
815 tests 814 ✔️ 1 💤 0
827 runs  826 ✔️ 1 💤 0

Results for commit 199212f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 23, 2024

Acceptance Tests

  17 files  255 suites   19m 20s ⏱️
581 tests 576 ✔️ 3 💤 2
915 runs  905 ✔️ 7 💤 3

Results for commit 199212f.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere closed this Apr 24, 2024
@ebadiere ebadiere reopened this Apr 24, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere merged commit 7d1afbc into main Apr 24, 2024
53 of 55 checks passed
@ebadiere ebadiere deleted the 2117-websocket-documentation-updates branch April 24, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhance the eth_subscribe implementation to support newHeads
2 participants