fix: removed ping method in WS server #2394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
georgi-l95,
Ivo-Yankov and
a team
as code owners
ebadiere
reviewed
Apr 23, 2024
quiet-node
force-pushed
the
2359-ws-socket-repetitively-responds-with-null-responses-when-subcribed
branch
from
6afbb25 to
d04af53
Compare
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
2359-ws-socket-repetitively-responds-with-null-responses-when-subcribed
branch
from
d04af53 to
27351ef
Compare
Signed-off-by: Logan Nguyen <[email protected]>
|
Comment on lines
203
to
207
| describe('Subscriptions for newHeads', async function () { | ||
| it('should subscribe to newHeads, include transactions true, and receive a valid JSON RPC response', (done) => { | ||
| process.env.WS_NEW_HEADS_ENABLED = 'true'; | ||
| const webSocket = new WebSocket(WS_RELAY_URL); | ||
| const subscriptionId = 1; |
There was a problem hiding this comment.
nit: We can extract the common setup logic in beforeEach:
describe('Subscriptions for newHeads', async function () {
+ let webSocket: WebSocket;
+ const subscriptionId = 1;
+
+ beforeEach(() => {
+ process.env.WS_NEW_HEADS_ENABLED = 'true';
+. webSocket = new WebSocket(WS_RELAY_URL);
+ });
it('should subscribe to newHeads, include transactions true, and receive a valid JSON RPC response', (done) => {
- process.env.WS_NEW_HEADS_ENABLED = 'true';
- const webSocket = new WebSocket(WS_RELAY_URL);
- const subscriptionId = 1;
...
});
it('should subscribe to newHeads, without the "include transactions", and receive a valid JSON RPC response', (done) => {
- process.env.WS_NEW_HEADS_ENABLED = 'true';
- const webSocket = new WebSocket(WS_RELAY_URL);
- const subscriptionId = 1;
...
});
it('should subscribe to newHeads, with "include transactions false", and receive a valid JSON RPC response', (done) => {
- process.env.WS_NEW_HEADS_ENABLED = 'true';
- const webSocket = new WebSocket(WS_RELAY_URL);
- const subscriptionId = 1;
...
});There was a problem hiding this comment.
Nice suggestion thanks a lot!
AlfredoG87
reviewed
Apr 24, 2024
There was a problem hiding this comment.
LG, @victor-yanev comment is a good improvement.
But more importantly, have we been able to resolve the issue that is closing the connection after 100 seconds? we decided to support 5 minutes right?
Should we want to remove this ping feature before being able to resolve the issue on the infrastructure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the ping method in the WS server to stop the server from repeatitively sending null responses back to client
misc: renamed one of the test case which was incorrect
Related issue(s):
Fixes #2359
Notes for reviewer:
Checklist