Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong gas estimation due to invalid tx object (#2377) #2392

Closed
wants to merge 1 commit into from

Conversation

AlfredoG87
Copy link
Collaborator

Description:
Cherry-pick #2377 onto release branch release/0.46

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* fix: wrong gas estimation due to invalid tx object

Signed-off-by: georgi-l95 <[email protected]>

optimization

Signed-off-by: georgi-l95 <[email protected]>

chore: fix typo

Signed-off-by: georgi-l95 <[email protected]>

test: add unit test

Signed-off-by: georgi-l95 <[email protected]>

fix logic

Signed-off-by: georgi-l95 <[email protected]>

delete input if not used

Signed-off-by: georgi-l95 <[email protected]>

* add simple fix

Signed-off-by: georgi-l95 <[email protected]>

* remove unused import

Signed-off-by: georgi-l95 <[email protected]>

* revert changes

Signed-off-by: georgi-l95 <[email protected]>

* fix acceptance tests

Signed-off-by: georgi-l95 <[email protected]>

* add unit tests

Signed-off-by: georgi-l95 <[email protected]>

---------

Signed-off-by: georgi-l95 <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AlfredoG87 AlfredoG87 closed this Apr 23, 2024
@AlfredoG87 AlfredoG87 deleted the cherrypick-2377-onto-46 branch April 23, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants