Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: broke total acceptancetest in ws-server into separate batches (#2382) #2383

Conversation

quiet-node
Copy link
Member

Description:
Currently there are about 300 acceptance test cases in the WS server, and they all run within one CI task with one instance of localnode. This often causes the Error: cannot find a healthy working node for many test cases. This PR attempts to break the one CI task into differnet separate batches to mitigatte heavy load on the localnode instance.

Related issue(s):

Fixes #2382

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.5% Duplication on New Code

See analysis details on SonarCloud

Copy link

Tests

    1 files    35 suites   3s ⏱️
194 tests 193 ✔️ 1 💤 0
197 runs  196 ✔️ 1 💤 0

Results for commit 2d47be3.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (3be2f94) to head (3a48c55).
Report is 12 commits behind head on main.

❗ Current head 3a48c55 differs from pull request most recent head 2d47be3. Consider uploading reports for the commit 2d47be3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2383   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines         644      644           
  Branches      118      118           
=======================================
  Hits          484      484           
  Misses        115      115           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 22, 2024

Acceptance Tests

  16 files  199 suites   16m 0s ⏱️
578 tests 572 ✔️ 4 💤 2
651 runs  645 ✔️ 4 💤 2

Results for commit 2d47be3.

♻️ This comment has been updated with latest results.

@quiet-node
Copy link
Member Author

closed as address in #2255

@quiet-node quiet-node closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide WS acceptance CI test into separate batches
2 participants