fix: updated MIRROR_NODE_RETRY_DELAY to 1800ms (#2371) #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
quiet-node
force-pushed
the
2371-increase-mirror_node_retry_delay-value-to-expand-the-delayed-duration-between-repeated-retries-to-the-mirror-nodes
branch
from
87be113 to
3cd96bb
Compare
quiet-node
force-pushed
the
2371-increase-mirror_node_retry_delay-value-to-expand-the-delayed-duration-between-repeated-retries-to-the-mirror-nodes
branch
from
4871272 to
a1315f5
Compare
quiet-node
force-pushed
the
2371-increase-mirror_node_retry_delay-value-to-expand-the-delayed-duration-between-repeated-retries-to-the-mirror-nodes
branch
from
a1315f5 to
9cd6c02
Compare
quiet-node
force-pushed
the
2371-increase-mirror_node_retry_delay-value-to-expand-the-delayed-duration-between-repeated-retries-to-the-mirror-nodes
branch
11 times, most recently
from
a81ba62 to
63f6c01
Compare
Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: updated MIRROR_NODE_RETRY_DELAY to 2000ms (#2371)" This reverts commit ec860ef. Update mirrorNodeClient.ts Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: updated MIRROR_NODE_RETRY_DELAY to 2000ms (#2371)" Signed-off-by: Logan Nguyen <[email protected]> test: divided ws-server total acceptancetest into batches Signed-off-by: Logan Nguyen <[email protected]> Revert "test: divided ws-server total acceptancetest into batches" This reverts commit 98f0bd2. test: divided ws-server total acceptancetest into batches (#2382) Signed-off-by: Logan Nguyen <[email protected]> fix: updated MIRROR_NODE_RETRY_DELAY to 2000ms (#2371) Signed-off-by: Logan Nguyen <[email protected]> Revert "test: divided ws-server total acceptancetest into batches" This reverts commit f7950f4.
quiet-node
force-pushed
the
2371-increase-mirror_node_retry_delay-value-to-expand-the-delayed-duration-between-repeated-retries-to-the-mirror-nodes
branch
from
63f6c01 to
d93fe9e
Compare
Signed-off-by: Logan Nguyen <[email protected]>
|
quiet-node
changed the title
quiet-node
deleted the
2371-increase-mirror_node_retry_delay-value-to-expand-the-delayed-duration-between-repeated-retries-to-the-mirror-nodes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
this PR updated the MIRROR_NODE_RETRY_DELAY to 1800ms to extend the delayed duration between repeated retries to the mirror node
Initially it was discussed to be 2000ms, but 2000ms seems a little bit long so eth_getLogs seems to skip blocks. In anoother way, instead of getting the logs in the consecutive block, with delay being 2000ms, eth_getLogs will jump to the second next block in the specified range.
Related issue(s):
Fixes #2371
Notes for reviewer:
Checklist