Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove specific version of NX dependency override. is working now. #2365

Merged
merged 1 commit into from
Apr 18, 2024
Merged

chore: Remove specific version of NX dependency override. is working now. #2365

merged 1 commit into from
Apr 18, 2024

Conversation

AlfredoG87
Copy link
Collaborator

Description:
Remove specific version of NX dependency override. is working now without it.
Related issue(s):

Fixes #1636

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 self-assigned this Apr 18, 2024
@AlfredoG87 AlfredoG87 added the dependencies Pull requests that update a dependency file label Apr 18, 2024
@AlfredoG87 AlfredoG87 added this to the 0.47.0 milestone Apr 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlfredoG87 AlfredoG87 mentioned this pull request Apr 18, 2024
Closed
@github-actions GitHub Actions
Copy link

Tests

    1 files    35 suites   3s ⏱️
194 tests 193 ✔️ 1 💤 0 ❌
197 runs  196 ✔️ 1 💤 0 ❌

Results for commit 5ae1ca5.

@AlfredoG87 AlfredoG87 marked this pull request as ready for review April 18, 2024 01:44
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner April 18, 2024 01:44
@github-actions GitHub Actions
Copy link

Acceptance Tests

     16 files     321 suites   18m 41s ⏱️
   583 tests    565 ✔️ 4 💤 14 ❌
1 182 runs  1 160 ✔️ 4 💤 18 ❌

Results for commit 5ae1ca5.

quiet-node
quiet-node approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@AlfredoG87 AlfredoG87 merged commit d68e16a into main Apr 18, 2024
28 checks passed
@AlfredoG87 AlfredoG87 deleted the 1636-remove-nx-override branch April 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node approved these changes

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

@ebadiere ebadiere Awaiting requested review from ebadiere

Assignees

@AlfredoG87 AlfredoG87

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
0.47.0
Development

Successfully merging this pull request may close these issues.

NX Dependency Override - remove whenever possible
2 participants
@AlfredoG87 @quiet-node