Revert "fix: added getContractResultsLogsWithRetry()"

This reverts commit fceb411. Signed-off-by: Logan Nguyen <[email protected]>
hashgraph · Dec 23, 2024 · a2e4317 · a2e4317
1 parent fceb411
commit a2e4317
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 41 deletions.
diff --git a/packages/relay/src/lib/clients/mirrorNodeClient.ts b/packages/relay/src/lib/clients/mirrorNodeClient.ts
@@ -892,25 +892,14 @@ export class MirrorNodeClient {
     return this.getQueryParams(queryParamObject);
   }
 
-  /**
-   * In some very rare cases the /contracts/results/logs api is called before all the data is saved in
-   * the mirror node DB and `transaction_index`, `block_number`, or `index` is returned as `undefined`.
-   * A single re-fetch is sufficient to resolve this problem.
-   *
-   * @param {RequestDetails} requestDetails - Details used for logging and tracking the request.
-   * @param {IContractLogsResultsParams} [contractLogsResultsParams] - Parameters for querying contract logs results.
-   * @param {ILimitOrderParams} [limitOrderParams] - Parameters for limit and order when fetching the logs.
-   * @returns {Promise<any[]>} - A promise resolving to the paginated contract logs results.
-   */
-  public async getContractResultsLogsWithRetry(
+  public async getContractResultsLogs(
     requestDetails: RequestDetails,
     contractLogsResultsParams?: IContractLogsResultsParams,
     limitOrderParams?: ILimitOrderParams,
-  ): Promise<any[]> {
-    const shortDelay = 250;
+  ) {
     const queryParams = this.prepareLogsParams(contractLogsResultsParams, limitOrderParams);
 
-    const logResults = await this.getPaginatedResults(
+    return this.getPaginatedResults(
       `${MirrorNodeClient.GET_CONTRACT_RESULT_LOGS_ENDPOINT}${queryParams}`,
       MirrorNodeClient.GET_CONTRACT_RESULT_LOGS_ENDPOINT,
       MirrorNodeClient.CONTRACT_RESULT_LOGS_PROPERTY,
@@ -919,31 +908,6 @@ export class MirrorNodeClient {
       1,
       MirrorNodeClient.mirrorNodeContractResultsLogsPageMax,
     );
-
-    for (const log of logResults) {
-      if (log && (log.transaction_index == null || log.block_number == null || log.index == null)) {
-        console.log(logResults);
-        if (this.logger.isLevelEnabled('debug')) {
-          this.logger.debug(
-            `${requestDetails.formattedRequestId} Contract result log contains undefined transaction_index, block_number, or index: transaction_hash:${log.transaction_hash}, transaction_index:${log.transaction_index}, block_number=${log.block_number}, log_index=${log.index}. Retrying after a delay of ${shortDelay} ms.`,
-          );
-        }
-
-        // Backoff before repeating request
-        await new Promise((r) => setTimeout(r, shortDelay));
-        return this.getPaginatedResults(
-          `${MirrorNodeClient.GET_CONTRACT_RESULT_LOGS_ENDPOINT}${queryParams}`,
-          MirrorNodeClient.GET_CONTRACT_RESULT_LOGS_ENDPOINT,
-          MirrorNodeClient.CONTRACT_RESULT_LOGS_PROPERTY,
-          requestDetails,
-          [],
-          1,
-          MirrorNodeClient.mirrorNodeContractResultsLogsPageMax,
-        );
-      }
-    }
-
-    return logResults;
   }
 
   public async getContractResultsLogsByAddress(

diff --git a/packages/relay/src/lib/services/ethService/ethCommonService/index.ts b/packages/relay/src/lib/services/ethService/ethCommonService/index.ts
@@ -322,7 +322,7 @@ export class CommonService implements ICommonService {
     if (address) {
       logResults = await this.getLogsByAddress(address, params, requestDetails);
     } else {
-      logResults = await this.mirrorNodeClient.getContractResultsLogsWithRetry(requestDetails, params);
+      logResults = await this.mirrorNodeClient.getContractResultsLogs(requestDetails, params);
     }
 
     if (!logResults) {

diff --git a/packages/relay/tests/lib/mirrorNodeClient.spec.ts b/packages/relay/tests/lib/mirrorNodeClient.spec.ts
@@ -795,7 +795,7 @@ describe('MirrorNodeClient', async function () {
   it('`getContractResultsLogs` ', async () => {
     mock.onGet(`contracts/results/logs?limit=100&order=asc`).reply(200, { logs: [log] });
 
-    const results = await mirrorNodeInstance.getContractResultsLogsWithRetry(requestDetails);
+    const results = await mirrorNodeInstance.getContractResultsLogs(requestDetails);
     expect(results).to.exist;
     expect(results.length).to.gt(0);
     const firstResult = results[0];