Nginx: add nginx to shell server #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aagat
suggested changes
Jun 29, 2018
ansible/tasks/nginx/main.yml
Outdated
| path: /etc/nginx/sites-enabled/default | ||
|
|
||
| - name: Restart nginx | ||
| when: nginxconf.chnaged |
| - name: Remove default nginx site | ||
| file: | ||
| state: absent | ||
| path: /etc/nginx/sites-enabled/default |
There was a problem hiding this comment.
Should we also remove /etc/nginx/sites-available/default ?
There was a problem hiding this comment.
/etc/nginx/sites-available/default is src of this symlink. there is no point to remove the original copy
|
@mayli why not use the nginx provided from Debian? |
RyanSquared
reviewed
Jun 30, 2018
| state: absent | ||
| path: /etc/nginx/sites-enabled/default | ||
|
|
||
| - name: Restart nginx |
There was a problem hiding this comment.
try to make this optional so that it doesn't fail if systemd isn't running (for instance, when setting up a build with Docker)
There was a problem hiding this comment.
This ought to be a handler, but that would depend on #68
KellerFuchs
approved these changes
Sep 16, 2018
| - name: Remove default nginx site | ||
| file: | ||
| state: absent | ||
| path: /etc/nginx/sites-enabled/default |
| state: absent | ||
| path: /etc/nginx/sites-enabled/default | ||
|
|
||
| - name: Restart nginx |
There was a problem hiding this comment.
This ought to be a handler, but that would depend on #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a reverse proxy of ~/.nginx.sock