Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SMS template test; stringify furl before returning JSON #2132

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update SMS template test; stringify furl before returning JSON #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion funnel/views/api/shortlink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,5 @@ def create_shortlink(
return {
'status': 'ok',
'shortlink': app_url_for(shortlinkapp, 'link', name=sl.name, _external=True),
'url': url,
'url': str(url),
}, status_code
2 changes: 1 addition & 1 deletion tests/unit/transports/sms_template_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,5 +237,5 @@ def test_web_otp_template() -> None:
t = sms.WebOtpTemplate(otp='1234')
assert str(t) == (
'OTP is 1234 for Hasgeek. If you did not request this, report misuse at '
'https://has.gy/not-my-otp\n\[email protected] #1234'
'https://hasgeek.com/account/not-my-otp\n\[email protected] #1234'
)
Loading