Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project page header #2030

Merged
merged 37 commits into from
May 31, 2024
Merged

Project page header #2030

merged 37 commits into from
May 31, 2024

Conversation

anishTP
Copy link
Contributor

@anishTP anishTP commented Apr 22, 2024

  • Moved the register block to the project-banner_right
  • Added a venue card to the right_col below navbar on the project page.
  • Changed order of the navbar render on mobile

funnel/templates/project.html.jinja2 Outdated Show resolved Hide resolved
funnel/templates/project_layout.html.jinja2 Outdated Show resolved Hide resolved
funnel/templates/project_layout.html.jinja2 Outdated Show resolved Hide resolved
funnel/templates/project_layout.html.jinja2 Outdated Show resolved Hide resolved
funnel/templates/project_layout.html.jinja2 Outdated Show resolved Hide resolved
funnel/templates/project_layout.html.jinja2 Outdated Show resolved Hide resolved
funnel/templates/project_layout.html.jinja2 Outdated Show resolved Hide resolved
@jace
Copy link
Member

jace commented Apr 27, 2024

The layout needs cleanup for some cases:

Member box alignment and missing icon for venue:
image

Everything is left aligned when there's no image, but the button's visual alignment is off:
image

Here the colour contrast works in the button's favour, but it needs margin from the text above it. The second button declaring "You are a member" is confusing as it has no relevance to this header:
image

@anishTP
Copy link
Contributor Author

anishTP commented Apr 29, 2024

The layout needs cleanup for some cases:

Member box alignment and missing icon for venue: image

Changed the size of the button to full-width when its the only child.
Replaced map-pin with map-marker-alt icon for the venue.
Screenshot 2024-04-29 at 5 11 52 PM

Everything is left aligned when there's no image, but the button's visual alignment is off: image

Added padding to above the button when there is no image and start-date. Also made it full-width when its the only child.

Screenshot 2024-04-29 at 5 10 52 PM

Here the colour contrast works in the button's favour, but it needs margin from the text above it. The second button declaring "You are a member" is confusing as it has no relevance to this header: image

The membership button could be removed since the header already has a label showing membership status. But it is necessary when the user is not a member.
Screenshot 2024-04-29 at 5 10 37 PM

anishTP and others added 20 commits April 29, 2024 17:21
* Style fixes and fix for follow button on homepage

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix follow button UI issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Style fixes for follow button on proposal card

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/pypa/pip-audit: v2.7.2 → v2.7.3](pypa/pip-audit@v2.7.2...v2.7.3)
- [github.com/astral-sh/ruff-pre-commit: v0.4.2 → v0.4.3](astral-sh/ruff-pre-commit@v0.4.2...v0.4.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@vidya-ram vidya-ram requested review from jace and djamg May 31, 2024 04:45
jace
jace previously approved these changes May 31, 2024
@vidya-ram vidya-ram merged commit 5d7240f into main May 31, 2024
10 of 11 checks passed
@vidya-ram vidya-ram deleted the project-page-header branch May 31, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants