Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more pooling layers to torch_nn.py #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

suzgunmirac
Copy link
Contributor

I realized that six of the pooling layers in torch.nn were initially missing, so I added them to torch_nn.py.

@srush
Copy link
Contributor

srush commented Feb 1, 2019

Looks great, but lint tests are failing. Be sure to run format.sh first.

@srush
Copy link
Contributor

srush commented Feb 1, 2019

Also be careful. MaxUnpool needs to indices, so it is not going to work.

input: the input Tensor to invert
indices: the indices given out by MaxPool3d

@srush
Copy link
Contributor

srush commented Feb 1, 2019

Changed around the nn style a bit. maybe we can update avg pool to the new style.

(honestly though we won't use any of these this assignment, they're more for images)

@suzgunmirac
Copy link
Contributor Author

Thank you so much for the update, Professor Rush! In this case, I will update the pooling layers once we finalize the nn style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants