Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and Revisions to efficient_ai.qmd with Professor Vijay's Feedback #313

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

Sara-Khosravi
Copy link
Contributor

Before submitting your Pull Request, please ensure that you have carefully reviewed and completed all items on this checklist.

  1. Content

    • The chapter content is complete and covers the topic in detail.
    • All technical terms are well-defined and explained.
    • Any code snippets or algorithms are well-documented and tested.
    • The chapter follows a logical flow and structure.
  2. References & Citations

    • All references are correctly listed at the end of the chapter.
    • In-text citations are used appropriately and match the references.
    • All figures, tables, and images have proper sources and are cited correctly.
  3. Quarto Website Rendering

    • The chapter has been locally built and tested using Quarto.
    • All images, figures, and tables render properly without any glitches.
    • All images have a source or they are properly linked to external sites.
    • Any interactive elements or widgets work as intended.
    • The chapter's formatting is consistent with the rest of the book.
  4. Grammar & Style

    • The chapter has been proofread for grammar and spelling errors.
    • The writing style is consistent with the rest of the book.
    • Any jargon is clearly explained or avoided where possible.
  5. Collaboration

    • All group members have reviewed and approved the chapter.
    • Any feedback from previous reviews or discussions has been addressed.
  6. Miscellaneous

    • All external links (if any) are working and lead to the intended destinations.
    • If datasets or external resources are used, they are properly credited and linked.
    • Any necessary permissions for reused content have been obtained.
  7. Final Steps

    • The chapter is pushed to the correct branch on the repository.
    • The Pull Request is made with a clear title and description.
    • The Pull Request includes any necessary labels or tags.
    • The Pull Request mentions any stakeholders or reviewers who should take a look.

@Sara-Khosravi
Copy link
Contributor Author

@profvjreddi

Hi Vijay,

I hope all is well! I have made enhancements and revisions to efficient_ai.qmd based on your feedback. This includes updating the image path, figure ID, and other improvements for consistency and clarity. 

I want to ensure we are on the same page, and I'll work closely with you to incorporate any further feedback you may have.

Additionally, I have discussed TinyML with my VP at Rogers, and there is a strong interest in exploring its use in our amplifiers. Your insights and further guidance on this topic would be greatly appreciated.

Please review the changes and let me know if any further adjustments are needed.

Thank you!
Sara

@profvjreddi
Copy link
Contributor

Hi @Sara-Khosravi just wanted to let you know that I am working through your pushes to look at the edits carefully, taking me a bit longer than usual cause of my schedule. But these PRs haven't gone unnoticed! : )

@Sara-Khosravi
Copy link
Contributor Author

Sara-Khosravi commented Jul 24, 2024 via email

@jasonjabbour jasonjabbour changed the base branch from dev to 353-student-feedback-chapter-eight August 15, 2024 05:07
@jasonjabbour jasonjabbour changed the base branch from 353-student-feedback-chapter-eight to sarah-chapter-8 August 15, 2024 05:38
@jasonjabbour jasonjabbour merged commit 3bce767 into harvard-edge:sarah-chapter-8 Aug 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants