Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Equi2Ico and Ico2Equi classes #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

viacheslav-m
Copy link

Created icosahedron util for angle calculation.
Created Equi2Ico numpy and torch runners.
Created Ico2Equi numpy and torch runners.

Created icosahedron util for angle calculation.
Created Equi2Ico numpy and torch runners.
Created Ico2Equi numpy and torch runners.
@haruishi43
Copy link
Owner

@viacheslav-m Hey thanks for adding a new function!

Before I can merge your work, I'd need to test it out and write some test codes to make sure that those functions are running as intended.
I'd appreciate it if you could give me some demo codes showing how equi2ico and ico2equi work.

Glancing through your code, I don't see many formatting errors, but if you could run black and format it, I'd appreciate that too! I'll look through the codes closely later.

Thanks again.

@viacheslav-m
Copy link
Author

@haruishi43 Hi! I am going to add comments for the code to become more clear. Also I can share with you my colab notebook with example of tests. I will be pleased to answer any questions you may have!

@haruishi43
Copy link
Owner

haruishi43 commented Sep 23, 2021

@viacheslav-m Okay, that would make understanding your code much easier since I haven't gone through papers for icosahedron transforms yet. I'd love to see some of the tests you did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants