Remove upper limit on dependent cookbooks and resolve all test errors #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RoboticCheese
The locked down dependencies were killing our ability to upgrade other cookbooks.
I see you are in the middle of a major overhaul, so I wanted to propose this option for an intermediate 1.3.1 code change that would free up the 3 year old cookbook locks in metadata.rb (which, at the time, were probably essential given the relatively unstable nature of many core cookbooks back then)
I followed the PR instructions and managed to get all rubocop, food critic, and rspec tests passing when running
rake, so I hope you find this advantageous in that respect, too--though it required many more lines be changed than I would have liked. But, that is an excellent test suite, I have to say.I am not sure what the diff to master will look like, but here is what the diff to v1.3.0 should look like:
v1.3.0...novu:dev/v1.3.1
Would you consider forking your master branch into a develop branch and replacing master with a current working version, such as this? We (and probably many others) would rather continue to rely on your cookbook than our own version, and such a rebranching to promote a 1.3.1 release would let us do that.
I am looking forward to any feedback. Thank you for your time.
--Kevin
Visual Diff from v1.3.0
v1.3.0...novu:dev/v1.3.1