Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps apt dependency to ~> 3.0 requiring chef 11+ #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vanwho
Copy link

@vanwho vanwho commented Jun 16, 2016

time to bump apt cookbook version, please. v3.0.0 removed compatibility for chef 10, but still supports chef 11+. Apt v4.0.0 is chef 12+, this PR only asks for ~> 3.0, maintaining Chef 11+

@RoboticCheese please review, merge, and version and release (I imagine as 2.0.0). many thanks

@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f5a26de on vanwho:apt3 into e45bd1b on RoboticCheese:master.

@vanwho
Copy link
Author

vanwho commented Jun 16, 2016

retest this please

@vanwho vanwho closed this Jun 16, 2016
@vanwho vanwho reopened this Jun 16, 2016
@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f5a26de on vanwho:apt3 into e45bd1b on RoboticCheese:master.

@vanwho
Copy link
Author

vanwho commented Jun 16, 2016

Problem restarting clamd service on CentOS 7 all options enabled, seems unrelated, hrm...

[92m       Recipe: clamav::services�[0m
[92m         * service[clamd] action enable�[0m
[92m           - enable service service[clamd]�[0m
[92m         * service[clamd] action start�[0m
[92m           �[0m
[92m           ==============================================================================�[0m
[92m           Error executing action `start` on resource 'service[clamd]'�[0m
[92m           ===============================================================================[0m
[92m           �[0m
[92m           Mixlib::ShellOut::ShellCommandFailed�[0m
[92m           ------------------------------------�[0m
[92m           Expected process to exit with [0], but received '1'�[0m
[92m           ---- Begin output of /sbin/service clamd start ----�[0m
[92m           STDOUT: Starting clamd (via systemctl):  [FAILED]�[0m
[92m           STDERR: Job for clamd.service failed because the control process exited with error code. See "systemctl status clamd.service" and "journalctl -xe" for details.�[0m
[92m           ---- End output of /sbin/service clamd start ----�[0m
[92m           Ran /bin/service clamd start returned 1�[0m
[92m           �[0m�[92m           Cookbook Trace:[0m
[92m           ---------------�[0m�[92m           /tmp/kitchen/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatcheschef/runner.rb:41:in `run_action'�[0m
[92m           �[0m
[92m           Resource Declaration:�[0m
[92m           ---------------------�[0m
[92m           # In /tmp/kitchen/cache/cookbooks/clamav/recipes/services.rb�[0m
[92m           �[0m
[92m            23: service c_service do�[0m
[92m            24:   supports status: true, restart: true�[0m
[92m            25:   action :nothing�[0m
[92m            26: end�[0m
[92m            27: �[0m
[92m           �[0m
[92m           Compiled Resource:�[0m
[92m           ------------------�[0m
[92m           # Declared in /tmp/kitchen/cache/cookbooks/clamav/recipes/services.rb:23:in `from_file'�0m
[92m           �[0m
[92m           service("clamd") do�[0m
[92m             action [:nothing]�[0m
[92m             updated true�[0m
[92m             supports {:status=>true, :restart=>true}�[0m
[92m             retries 0�[0m
[92m             retry_delay 2�[0m
[92m             default_guard_interpreter :default�[0m
[92m             service_name "clamd"�[0m
[92m             enabled true�[0m
[92m             pattern "clamd"�[0m
[92m             declared_type :service�[0m
[92m             cookbook_name "clamav"�[0m
[92m             recipe_name "services"�[0m
[92m           end�[0m
[92m           �[0m
[92m           Platform:�[0m
[92m           ---------�[0m
[92m           x86_64-linux�[0m
[92m           �[0m
[92m         * service[freshclam] action enable�[0m
[92m           - enable service service[freshclam]�[0m
[92m         * service[freshclam] action start�[0m
[92m           - start service service[freshclam]�[0m
[92m         * service[clamd] action restart�[0m
[92m           �[0m
[92m           ==============================================================================�[0m
[92m           Error executing action `restart` on resource 'service[clamd]'�[0m
[92m           ==============================================================================�[0m
[92m           �[0m
[92m           Mixlib::ShellOut::ShellCommandFailed�[0m
[92m           ------------------------------------�[0m
[92m           Expected process to exit with [0], but received '1'�[0m
[92m           ---- Begin output of /sbin/service clamd restart ----�[0m
[92m           STDOUT: Restarting clamd (via systemctl):  [FAILED]�[0m
[92m           STDERR: Job for clamd.service failed because the control process exited with error code. See "systemctl status clamd.service" and "journalctl -xe" for details.�[0m
[92m           ---- End output of /sbin/service clamd restart ----�[0m
[92m           Ran /sbin/service clamd restart returned 1�[0m
[92m           �[0m
[92m           Cookbook Trace:[0m
[92m           ---------------�[0m[92m           /tmp/kitchen/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatcheschef/runner.rb:41:in `run_action'�[0m
[92m           �[0m
[92m           Resource Declaration:�[0m
[92m           ---------------------�[0m
[92m           # In /tmp/kitchen/cache/cookbooks/clamav/recipes/services.rb�[0m
[92m           �[0m
[92m            23: service c_service do�[0m
[92m            24:   supports status: true, restart: true�[0m
[92m            25:   action :nothing�[0m
[92m            26: end�[0m
[92m            27: �[0m
[92m           �[0m
[92m           Compiled Resource:�[0m
[92m           ------------------�[0m
[92m           # Declared in /tmp/kitchen/cache/cookbooks/clamav/recipes/services.rb:23:in `from_file'�0m
[92m           �[0m
[92m           service("clamd") do�[0m
[92m             action [:nothing]�[0m
[92m             updated true�[0m
[92m             supports {:status=>true, :restart=>true}�[0m
[92m             retries 0�[0m
[92m             retry_delay 2�[0m
[92m             default_guard_interpreter :default�[0m
[92m             service_name "clamd"�[0m
[92m             enabled true�[0m
[92m             pattern "clamd"�[0m
[92m             declared_type :service�[0m
[92m             cookbook_name "clamav"�[0m
[92m             recipe_name "services"�[0m
[92m           end�[0m
[92m           �[0m
[92m           Platform:�[0m
[92m           ---------�[0m
[92m           x86_64-linux�[0m
[92m           �[0m
[92m         * service[freshclam] action restart�[0m
[92m           - restart service service[freshclam]�[0m
[92m       �[0m
[92m       Running handlers:�[0m
[92m       [2016-06-16T14:42:57+00:00] ERROR: Running exception handlers�[0m
[92m       Running handlers complete�[0m
[92m       [2016-06-16T14:42:57+00:00] ERROR: Exception handlers complete�[0m
[92m       Chef Client failed. 36 resources updated in 01 minutes 19 seconds�[0m
[92m       [2016-06-16T14:42:57+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out�[0m
[92m       [2016-06-16T14:42:57+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report�[0m
[92m       [2016-06-16T14:42:57+00:00] ERROR: Chef::Exceptions::MultipleFailures�[0m
[92m       [2016-06-16T14:42:58+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)�[0m
[31m>>>>>> Converge failed on instance <all-options-enabled-centos-7>

@vanwho vanwho closed this Jun 17, 2016
@vanwho vanwho reopened this Jun 17, 2016
@coveralls
Copy link

coveralls commented Jun 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f5a26de on vanwho:apt3 into e45bd1b on RoboticCheese:master.

@vanwho vanwho closed this Jun 27, 2016
@vanwho vanwho reopened this Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants