Added update product api changes with price change event #2
Conversation
|
Move the IntegrationEventLog related changes to a different project. |
| System.out.println("publishThroughEventBus " +event); | ||
| eventLogService.markEventAsInProgress(event.getId()).then(eventBus.publish(event)) | ||
| .then(eventLogService.markEventAsPublished(event.getId())); | ||
| return Mono.empty(); |
There was a problem hiding this comment.
Why return Mono.empty() ? return the chaining of Monos ? I guess that itself will return mono
|
|
||
|
|
||
| public Mono<Void> saveEventAndCatalogChanges(IntegrationEvent event, CatalogItem requestedItem) { | ||
| catalogItemRepository.save(requestedItem); |
There was a problem hiding this comment.
chaining not implemented here.
| <dependency> | ||
| <groupId>io.r2dbc</groupId> | ||
| <artifactId>r2dbc-mssql</artifactId> | ||
| <version>1.0.0.RELEASE</version> | ||
| </dependency> | ||
| <version>0.9.0.RELEASE</version> |
There was a problem hiding this comment.
Lowered r2dbc version to fix ClassCastException from Long to Integer while saving IntegrationEventLogEntry entity
Ref : spring-projects/spring-framework#28864
| private EventStateEnum(int value) { | ||
| this.value = value; | ||
| } | ||
| public int getValue() { |
There was a problem hiding this comment.
Added getValue for Enum as navchar2(Ex : EventStateEnum.NOT_PUBLISHED) cannot be persisted to int in db.
Need to revisit
|
|
||
| @Override | ||
| @Transient | ||
| public boolean isNew() { |
There was a problem hiding this comment.
Added super class of Peristable for the similar error
Failed to update table [user]. Row with Id [475471b9-118a-401b-a505-03c701560f9e1579010919455] does not exist
| } | ||
|
|
||
| @PersistenceConstructor | ||
| public IntegrationEventLogEntry(UUID eventId, String content, LocalDateTime creationTime, String eventTypeName, |
There was a problem hiding this comment.
Added another constructor to make transient fields non require
No description provided.