Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Publish all drafts #391

Merged

Conversation

jakubbortlik
Copy link
Collaborator

@jakubbortlik jakubbortlik commented Oct 10, 2024

This fixes an issue where running require("gitlab").publish_all_drafts() would result in the error gitlab.nvim: Could not parse JSON request body: json: cannot unmarshal array into Go value of type app.DraftNotePublishRequest because of empty body in lua/gitlab/actions/draft_notes/init.lua line 87.

M.confirm_publish_all_drafts = function()
  local body = {}

Besides, this adds a notification to the user when the server is successfully built.

@harrisoncramer harrisoncramer merged commit 7171f4c into harrisoncramer:develop Oct 10, 2024
6 checks passed
@jakubbortlik jakubbortlik deleted the fix-publish-all-drafts branch October 11, 2024 07:51
harrisoncramer added a commit that referenced this pull request Oct 13, 2024
fix: Error messages and run all tests (#381)
feat: Automatically open fold under cursor (#380)
fix: Discussion ID is not required (#383)
chore: Add more emojis (#384)
fix: Publish all drafts (#391)
fix: Make discussion tree buffers no-modifiable (#394)
fix: Incorrect warning about commits (#395)
fix: Show draft replies in the correct tree (#396)
fix: Cannot choose merge requests (#398)

---------

Co-authored-by: George Kontridze <[email protected]>
Co-authored-by: Jakub F. Bortlík <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants