fix: Fixes issues w/ shared pointers to structs #378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd introduced a middleware pattern that was validating structs. The middleware was set up in the server with pointers to structs, like this:
This caused the struct data to be shared across requests! This was causing issues where payload fields were being shared between API calls. We want new payloads for every API call.
This MR adjusts the code to add a new factory function on the
methodToPayload
map that creates a new payload per request so that data is not shared across them.The new pattern is like this:
Where
newPayload
creates a new instance of the type provided and returns a pointer to that value in memory.