Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Add Payload Validators + Middleware In Go Code #366

Merged
merged 46 commits into from
Sep 12, 2024
Merged

Refactor: Add Payload Validators + Middleware In Go Code #366

merged 46 commits into from
Sep 12, 2024

Conversation

harrisoncramer
Copy link
Owner

@harrisoncramer harrisoncramer commented Sep 12, 2024 •
edited
Loading

This MR refactors the Go code to introduce a middleware pattern. It then moves several repeated patterns into these middleware and improves the endpoints by adding validators. It makes the following changes:

  • Adds validators to the payloads to enforce required payload fields
  • Moves method validation into middleware
  • Moves payload validation into middleware
  • Moves getting the MR ID into middleware
  • Updates + simplifies error responses + status codes
  • Adds global logging for both to/from Go server, and to/from Gitlab, changes logging configuration slightly

@harrisoncramer
Added go validator package
f582971
@harrisoncramer
Converted handler => ServeHTTP on http.Handler interface
0e827e6
@harrisoncramer
Extracted log functions
c7e675f
@harrisoncramer
Set up middlware
9a516fd
@harrisoncramer
Added middlwares for validating and parsing payloads
15b1417
@harrisoncramer
Wrote middleware for method checking
d0f153b
@harrisoncramer
Added test for resolving merge request
03b53b6
@harrisoncramer
Formats errors
030d552
@harrisoncramer
Added test for method not allowed
a0f1a32
@harrisoncramer
Testing some error from Gitlab
03d8c8c
@harrisoncramer
Updated approve.go and approve_test.go
0b09239
@harrisoncramer
Updated validations
16fd984
@harrisoncramer
Updated payload validator per method (PUT/PATCH/GET)
0297cbf
@harrisoncramer
Updated comment.go and comment_test.go
c3772a6
@harrisoncramer
Moved around types in comment.go
0753921
@harrisoncramer
Added more tests
777a407
@harrisoncramer
Pulled out withMR
a16747e
@harrisoncramer
moved other routes
3a27e77
@harrisoncramer
Added middleware test
a4eff13
@harrisoncramer
Removed method tests
186844c
@harrisoncramer
Added more middleware tests
db4cd2e
@harrisoncramer
Added more tests
409d697
@harrisoncramer
Added test for validating payloads
d533a6a
@harrisoncramer
Moved over list discussions
5a5e6c8
@harrisoncramer
Migrated attachment service
d853dbb
@harrisoncramer
create_mr
1103bb7
@harrisoncramer
draft_note_publisher
190c814
@harrisoncramer
draft_notes
8d31913
@harrisoncramer
Fixed info
4af3d9f
@harrisoncramer
job
3e5238e
@harrisoncramer harrisoncramer changed the base branch from main to develop September 12, 2024 17:56
@harrisoncramer harrisoncramer marked this pull request as ready for review September 12, 2024 18:51
@harrisoncramer harrisoncramer merged commit 9f963d5 into develop Sep 12, 2024
6 checks passed
@harrisoncramer harrisoncramer mentioned this pull request Sep 13, 2024
Merged
harrisoncramer added a commit that referenced this pull request Sep 14, 2024
@harrisoncramer
fix: date fixes; go middleware refactors; regex fixes; etc (#368)
22bfd0c 
fix: format of date when MR was closed or merged (#367)
refactor: Add Payload Validators + Middleware In Go Code (#366)
fix: Add better checks for leaving comments (#369)
fix: regex support for http credentials embedded in remote url (#372)
fix: Comment on single line selects two lines (#371)

This is a #PATCH release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harrisoncramer