Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Splitting Up Go Interfaces #354

Merged
merged 56 commits into from
Sep 5, 2024
Merged

Refactor: Splitting Up Go Interfaces #354

merged 56 commits into from
Sep 5, 2024

Conversation

harrisoncramer
Copy link
Owner

@harrisoncramer harrisoncramer commented Sep 5, 2024 •
edited
Loading

This MR refactors the Go codebase into a more modular and idiomatic format by:

  • Splitting apart the large client interface into separate interfaces per handler
  • Using those smaller interfaces in route-based tests
  • Removing our mocks and mock dependency and using fakes instead
  • Moving the app code into a separate package from the main package

harrisoncramer and others added 30 commits August 23, 2024 14:01
@harrisoncramer
Add Filtering, HealthCheck, Better Tests (#350)
4ae623c 
feat: add filtering when choosing merge requests (#346)
feat: Add healthcheck (#345)
refactor: Move to gomock (#349)
feat: Makes the remote of the plugin configurable (#348)

This is a #MINOR release.
@harrisoncramer
Moving into modules
d939161
@harrisoncramer
Checkpoint #1
7e9911f
@harrisoncramer
Set plugin options
4104643
@harrisoncramer
Converting more handlers
190b60d
@harrisoncramer
Pipeline service
57ea5fa
@harrisoncramer
Handled withMr middleware
b9502db
@harrisoncramer
Continuing work on breaking apart services
62feafa
@harrisoncramer
Renaming server/creator
30f0c40
@harrisoncramer
Split apart draft note publisher + manager
7fd4633
@harrisoncramer
Updated cmd/app/emoji.go
6bc9529
@harrisoncramer
Updated emoji handler
d71d268
@harrisoncramer
Merge request revoker service
4d90308
@harrisoncramer
Migrated label handler
b5d8582
@harrisoncramer
Reply service
d0fb136
@harrisoncramer
Cleaned up withMr middleware
ba6bae6
@harrisoncramer
Revisions service
50b6ea9
@harrisoncramer
Reviewer service
87cad1d
@harrisoncramer
Summary service
4ab09e6
@harrisoncramer
More services
791cc68
@harrisoncramer
Discussion resolution svc
6c065d9
@harrisoncramer
Updated merge request accepter service
b4c5ca0
@harrisoncramer
Comment service
74ebb3b
@harrisoncramer
Merge request approver service
f4b06a4
@harrisoncramer
Fixed emoji/list discussions separation
e9686d5
@harrisoncramer
Make tests pass
1b61ee1
@harrisoncramer
Moved out utilities
50ec55c
@harrisoncramer
Updated cmd/app/approve_test.go
47a0a75
@harrisoncramer
Converted more tests
dd0ab02
@harrisoncramer
Fixed attachment_test.go
242f6ab
@harrisoncramer
Updated cmd/app/comment_test.go
4153493
@harrisoncramer
Updated cmd/app/comment_test.go
ed6a2f6
@harrisoncramer
Fixed comment tests
f6ee6f3
@harrisoncramer
Fixed create_mr_test.go
997b96d
@harrisoncramer
Removed gomock
7994237
@harrisoncramer
Updated .github/CONTRIBUTING.md
758546f
@harrisoncramer
Updated draft notes
40f0927
@harrisoncramer
Updated cmd/app/draft_notes_test.go
68c4eaa
@harrisoncramer
Updated draft note publisher test
f1ff160
@harrisoncramer
Renaming + cleanup
fc07cab
@harrisoncramer
Updated info/info_test
4de72d6
@harrisoncramer
Updated job_test.go
b0918af
@harrisoncramer
Fixed list_discussions test
4ebf236
@harrisoncramer
Updated members_test
3f1feb7
@harrisoncramer
List merge requests
5a7e70d
@harrisoncramer
Renamed merge.go => merge_mr.go
db13f6b
@harrisoncramer
Updated merge_mr test
65c410c
@harrisoncramer
Added pipeline tests
47ce17c
@harrisoncramer
Added reply test
05dd3fb
@harrisoncramer
Updated cmd/app/test_helpers.go
de9bda5
@harrisoncramer
Merge branch 'develop' into breaking-apart-modules
191c3a3
@harrisoncramer
added back lua changes
9505691
@harrisoncramer
Fixed tests, fixed linting
99dba1a
@harrisoncramer
Fixed modules
be071c6
@harrisoncramer
Updated .github/workflows/go.yaml
64a3e95
@harrisoncramer
Removed slices reference (we are on Go 1.19)
f7d5d6c
@harrisoncramer harrisoncramer marked this pull request as ready for review September 5, 2024 18:00
@harrisoncramer harrisoncramer merged commit 6df467c into develop Sep 5, 2024
6 checks passed
@harrisoncramer harrisoncramer mentioned this pull request Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harrisoncramer