Update readme and name #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
reviewed
Jul 25, 2024
| * harfruzz does not yet fully pass the harfbuzz shaping or fuzzing tests | ||
| * Malformed fonts will cause an error | ||
| * HarfBuzz uses fallback/dummy shaper in this case | ||
| * No Arabic fallback shaper (requires subsetting) |
There was a problem hiding this comment.
This has always been confusingly worded. The fallback shaper uses some of the font serialization code in HarfBuzz (which exists mainly to help with subsetting code) to build lookups on the fly, but it does not require subsetting the fonts.
There was a problem hiding this comment.
Ty, will clarify in a followon
Merged
|
Is it too late to change the name?
|
|
I'd love a Norse name but I want to respect that this is Behdads library
and choice of name.
…On Fri, Jul 26, 2024, 5:28 AM Abdul Rahman Sibahi ***@***.***> wrote:
Is it too late to change the name? harfruzz is a terrible name.
skapa goes with the theme of Old Norse names
—
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRKXAAIVKJFBR4IFYOYRZDZOICDXAVCNFSM6AAAAABLOSG2S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSGIZTKNZTGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1 and gets us building w/new name.
rendered