Isolate AAT tables #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the ttf-parser code for script, langsys and feature lookup. GSUB/GPOS is now fully fontations.
Replace `ttf_parser::Tag` with `font_types::Tag` throughout the code.
Captures lookup of all the AAT types into a new type and builds them directly from table data rather than going through `ttf_parser::Face`. This will allow us to remove `ttf_parser::Face` from `hb_font_t` before AAT support in `read-fonts` is done and will enable us to replace those tables one at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captures lookup of all the AAT tables into a new type and builds them directly from table data rather than going through
ttf_parser::Face.This will allow us to remove
ttf_parser::Facefromhb_font_tbefore AAT support inread-fontsis done and will enable us to replace those tables one at a time.Builds on #10