-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the possibility to return all the possible solutions using the from_sample_point static methods #1671
add the possibility to return all the possible solutions using the from_sample_point static methods #1671
Conversation
…om_sample_point static methods
Both me and mypy do not like the different return types of the What do you think about adding another method which generates BitTiming instances:
The |
…danielhrisca/python-can into from_sample_point_all_solutions
… from_sample_point_all_solutions
@zariiii9003 thanks for the pointers, let me know if the new code is ok |
Looks good, could you add some trivial test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you 👍
The CAN databases can contain restrictions for the timings:
With this change the user can get all the possible solutions for a given sampling value and can further filter the solutions using the known constraints.