Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value set interversion fix #1851

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Value set interversion fix #1851

merged 7 commits into from
Dec 9, 2024

Conversation

lmckenzi
Copy link
Collaborator

@lmckenzi lmckenzi commented Dec 8, 2024

The extension was using a child extension of "value" rather than "value[x]", which is what we'd agreed to. Also added support for this in R4B

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.84%. Comparing base (d9fab89) to head (7d0822a).
Report is 44 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1851      +/-   ##
============================================
+ Coverage     12.82%   12.84%   +0.02%     
- Complexity    33333    33439     +106     
============================================
  Files          2225     2228       +3     
  Lines        677185   677929     +744     
  Branches     199496   199689     +193     
============================================
+ Hits          86822    87107     +285     
- Misses       559596   559957     +361     
- Partials      30767    30865      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@grahamegrieve grahamegrieve merged commit 0d6f658 into master Dec 9, 2024
33 checks passed
@grahamegrieve grahamegrieve deleted the ValueSetInterversionFix branch December 9, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants