Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1777: FML Parser in StructureMapUtilities and id transform #1778

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oliveregger
Copy link
Contributor

That the test run through the PR FHIR/fhir-test-cases#195 needs to be integrated.

See description for PR in #1777

Copy link
Collaborator

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with this bit:

  if (!(context.getVersion().equals("5.0.0"))) {
    throw new FHIRException("FHIR version needs to be 5.0.0");
  }

??

Copy link
Collaborator

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ObjectConverter has a method to do the ElementModel -> Resource conversion

@oliveregger
Copy link
Contributor Author

what's with this bit:

  if (!(context.getVersion().equals("5.0.0"))) {
    throw new FHIRException("FHIR version needs to be 5.0.0");
  }

??

I added this, because we use the R5 functionality in an R4 instance. StructureMapUtilities does not work with an R4 context and after noticing the problem, I added this safeguard. but no problem in removing it.

@oliveregger
Copy link
Contributor Author

the narrative generation has also changed with FML Parser, that the test run through, I updated the testcase here:
FHIR/fhir-test-cases#211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants