Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result column to migration table #6580

Merged
merged 19 commits into from
Jan 6, 2025
Merged

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Dec 28, 2024

A new RESULT column has been added to the database migration table to record the migration execution result.
values are:

  • NOT_APPLIED_SKIPPED (either skipped via the skip-versions flag or if the migration task was stubbed),
  • NOT_APPLIED_NOT_FOR_THIS_DATABASE (does not apply to that database),
  • NOT_APPLIED_PRECONDITION_NOT_MET (not run based on a SQL script outcome),
  • NOT_APPLIED_ALLOWED_FAILURE (the migration failed, but it is permitted to fail)
  • APPLIED.

@fil512 fil512 requested a review from a team as a code owner December 28, 2024 19:25
Copy link

github-actions bot commented Dec 28, 2024

Formatting check succeeded!

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved

@fil512 fil512 enabled auto-merge (squash) January 6, 2025 18:16
Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending comments. I imagine all existing columns will just be null, which is fine.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (406db33) to head (b2628c3).
Report is 147 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6580      +/-   ##
============================================
- Coverage     83.54%   83.49%   -0.05%     
- Complexity    27432    28526    +1094     
============================================
  Files          1707     1795      +88     
  Lines        106185   111059    +4874     
  Branches      13397    13953     +556     
============================================
+ Hits          88710    92729    +4019     
- Misses        11750    12353     +603     
- Partials       5725     5977     +252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fil512 fil512 merged commit f2f069f into master Jan 6, 2025
65 of 67 checks passed
@fil512 fil512 deleted the khs-20241228-migration-columns branch January 6, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants