-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add result column to migration table #6580
Conversation
Formatting check succeeded! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approved
...r-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7_8_0/6580-migration-result-column.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending comments. I imagine all existing columns will just be null, which is fine.
...r-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7_8_0/6580-migration-result-column.yaml
Outdated
Show resolved
Hide resolved
...r-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7_8_0/6580-migration-result-column.yaml
Outdated
Show resolved
Hide resolved
...r-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7_8_0/6580-migration-result-column.yaml
Outdated
Show resolved
Hide resolved
...r-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/7_8_0/6580-migration-result-column.yaml
Outdated
Show resolved
Hide resolved
…_8_0/6580-migration-result-column.yaml Co-authored-by: Tadgh <[email protected]>
…_8_0/6580-migration-result-column.yaml Co-authored-by: Tadgh <[email protected]>
…_8_0/6580-migration-result-column.yaml Co-authored-by: Tadgh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6580 +/- ##
============================================
- Coverage 83.54% 83.49% -0.05%
- Complexity 27432 28526 +1094
============================================
Files 1707 1795 +88
Lines 106185 111059 +4874
Branches 13397 13953 +556
============================================
+ Hits 88710 92729 +4019
- Misses 11750 12353 +603
- Partials 5725 5977 +252 ☔ View full report in Codecov by Sentry. |
A new
RESULT
column has been added to the database migration table to record the migration execution result.values are:
NOT_APPLIED_SKIPPED
(either skipped via theskip-versions
flag or if the migration task was stubbed),NOT_APPLIED_NOT_FOR_THIS_DATABASE
(does not apply to that database),NOT_APPLIED_PRECONDITION_NOT_MET
(not run based on a SQL script outcome),NOT_APPLIED_ALLOWED_FAILURE
(the migration failed, but it is permitted to fail)APPLIED
.