Issue with combo index search parameter when using date

[epeartree]

the problem:
Given a combo index search parameters configured with a date search parameter components, combo index searching is skipped when a date query parameter value is submitted to the search stack.

root cause:
The root cause of the problem is that when we marshal query string 'birthdate=2021-01-01' into a DateRangeParam before submission to the search layer, a default prefix of 'EQUAL' is assigned to both DateParam objects encapsulated by the dateRangeParam. Due to the presence of the prefix, the search layer skips combo indexes inspection.

The issue described above evolved into harmonising the search logic behaviour in favour of allowing combo indexes inspection even with the 'eq' prefix since date=2021-01-01 is equivalent to date=eq2021-01-01 searches.

what was done:

• Modified class DateRangeParam to not default the prefix to 'EQUAL' as doing so would make it impossible for indexes created by a combo search index parameters to be queried during searches;
• added utility method and comment to return a prefix of 'equal' when performing computation based on prefix value;
• Modified class SearchBuilder to allow combo indexes inspection when a date query string is prefixed with 'eq';
• Added a unit test to class FhirResourceDaoR4ComboNonUniqueParamTest;
• added changelog;

[github-actions]

Formatting check succeeded!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (406db33) to head (106c0ce).
Report is 162 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6566      +/-   ##
============================================
- Coverage     83.54%   83.50%   -0.05%     
- Complexity    27432    28560    +1128     
============================================
  Files          1707     1797      +90     
  Lines        106185   111142    +4957     
  Branches      13397    13961     +564     
============================================
+ Hits          88710    92804    +4094     
- Misses        11750    12351     +601     
- Partials       5725     5987     +262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmarchionatto]

Fix looks good, but there is no test for the specific point of the fix, which is that the combo search is now considered. Please add test for that case.

changes were made and approved