Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #10

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

refactor #10

wants to merge 6 commits into from

Conversation

typoverflow
Copy link
Collaborator

Hi Haotian, I drafted this pull request to better illustrate the structural changes. I think there are some things we can do:

  • 1. extract a package, spectralrl, to manage the codes and to distribute the codes conveniently with pypi.
  • 2. use hydra for argument parsing, instead of argparse, since different algorithms require different sets of arguments
  • 3. refactor those image-based algorithms (namely MuLVRep, DiffSR and DrQv2), so that they share the same pipeline and just differ in the implementation of the agents
  • 4. refactor the codes for state-based algorithms.

Currently, I have partially completed 1-3 (see spectral/ and examples/main_visual.py). I am still testing the image-based algorithms to make sure they behave in the same way as the original implementations. Could you help with refactoring the state-based algorithms if possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant