Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Haotian, I drafted this pull request to better illustrate the structural changes. I think there are some things we can do:
spectralrl
, to manage the codes and to distribute the codes conveniently with pypi.hydra
for argument parsing, instead ofargparse
, since different algorithms require different sets of argumentsCurrently, I have partially completed 1-3 (see
spectral/
andexamples/main_visual.py
). I am still testing the image-based algorithms to make sure they behave in the same way as the original implementations. Could you help with refactoring the state-based algorithms if possible?