test: close client after test runs

hannahramadan · Jul 24, 2024 · 401e3fc · 401e3fc
1 parent f9ac292
commit 401e3fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/instrumentation/pg/test/fixtures/sql_table_name.json b/instrumentation/pg/test/fixtures/sql_table_name.json
@@ -15,6 +15,10 @@
       "name": "insert_into",
       "sql": "INSERT INTO table_name (column1, column2) VALUES (value1, value2)"
     },
+    {
+      "name": "drop_table",
+      "sql": "DROP TABLE table_name"
+    },
     {
       "name": "update",
       "sql": "UPDATE table_name SET column1 = value1 WHERE condition"

diff --git a/instrumentation/pg/test/opentelemetry/instrumentation/pg/instrumentation_test.rb b/instrumentation/pg/test/opentelemetry/instrumentation/pg/instrumentation_test.rb
@@ -36,6 +36,7 @@
   after do
     # Force re-install of instrumentation
     instrumentation.instance_variable_set(:@installed, false)
+    client&.close
   end
 
   describe 'tracing' do
@@ -268,9 +269,10 @@
     end
 
     it 'extracts table name' do
-      client.query('CREATE TABLE IF NOT EXISTS test_table (personid int, name VARCHAR(50))')
+      client.query('CREATE TABLE test_table (personid int, name VARCHAR(50))')
 
       _(span.attributes['db.collection.name']).must_equal 'test_table'
+      client.query('DROP TABLE test_table') # Drop table to avoid conflicts
     end
 
     describe 'when db_statement is obfuscate' do