Add http handlers for createclaim/sendclaim #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds http handlers for the createclaim/sendclaim rpc methods. This was made for shakestation so I could select which wallet to create/send claims from without having to rpc selectwallet which could potentially break other scripts that may have been running at the same time.
|
I think it would be more appropriate if it followed convention for the name related endpoints.
Accepting post data: |
Falci
suggested changes
May 10, 2024
Comment on lines
+1446
to
+1447
| const name = valid.str('name'); | ||
|
|
There was a problem hiding this comment.
Suggested change
| const name = valid.str('name'); | |
| const name = valid.str('name'); | |
Comment on lines
+1466
to
+1467
| const name = valid.str('name'); | ||
|
|
There was a problem hiding this comment.
Suggested change
| const name = valid.str('name'); | |
| const name = valid.str('name'); | |
nodech
added
waiting for the author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds http handlers for the createclaim/sendclaim rpc methods.
This was made for shakestation so I could select which wallet to create/send claims from without having to rpc selectwallet which could potentially break other scripts that may have been running at the same time.