Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export HTTP.TransactionOptions #670

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Export HTTP.TransactionOptions #670

merged 1 commit into from
Dec 9, 2021

Conversation

nodech
Copy link
Contributor

@nodech nodech commented Dec 9, 2021

Fixes the style issues in that PR.

Closes #392

@nodech nodech self-assigned this Dec 9, 2021
@nodech nodech added wallet part of the codebase wallet-api part of the codebase wallet-http part of the codebase quick review difficulty - easy labels Dec 9, 2021
@coveralls
Copy link

coveralls commented Dec 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1558282263

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.488%
Files with Coverage Reduction New Missed Lines %
lib/covenants/rules.js 1 69.11%
lib/protocol/consensus.js 1 82.79%
lib/script/script.js 1 63.25%
lib/net/pool.js 2 30.34%
lib/wallet/http.js 3 63.53%
Totals Coverage Status
Change from base Build 1521306511: -0.02%
Covered Lines: 21236
Relevant Lines: 31792
💛 - Coveralls

@nodech nodech force-pushed the export-transactionoptions-fix branch from 338341a to 68e6610 Compare December 9, 2021 10:31
@nodech nodech merged commit e1d3969 into handshake-org:master Dec 9, 2021
@nodech nodech added the patch Release version label Dec 9, 2021
@nodech nodech deleted the export-transactionoptions-fix branch January 6, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nodech nodech

Labels
patch Release version quick review difficulty - easy wallet part of the codebase wallet-api part of the codebase wallet-http part of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodech @coveralls @wi-ski