dns/ns/resource: send REFUSED if name contains special characters (big fix 2/4) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinheadmz
changed the title
pinheadmz
force-pushed
the
dirty-name-test
branch
from
76edbd0
to
a18485c
Compare
pinheadmz
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored out of bloated #76
Refactors
hsk_dns_name_dirty()to more resemble rules.verifyString() from hsd.We used to do this check every time we wrote a name coming or going, but I pulled it out everywhere and now we just check it when a request is being made (essentially to sanitize incoming strings).