Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for “self-identification” #234

Merged
merged 1 commit into from
Apr 13, 2016
Merged

Conversation

smondet
Copy link
Member

@smondet smondet commented Apr 13, 2016

This fixes #213.


This change is Reviewable

@smondet smondet merged commit ebb0d9d into master Apr 13, 2016
smondet added a commit that referenced this pull request Apr 13, 2016
@@ -122,6 +122,11 @@ module Make_fun = struct
["#WIP"]). *)
| `Custom of string (** Pass arbitrary data (useful for temporary
extensions/experiements outside of Biokepi). *)
| `Self_identification of string list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be nicer to match with downstream as just Self_identification of string instead.

We could also use a type instead. If we used a type instead of a string, Merlin/the compiler could help us figure out what we can match on. As it is, someone will have to go through the source code to figure out what they can match on (and it could change/break on them in the future without a warning).

(Still not sure, even with the Hamkepi PR, that this solution is as simple for the user as passing ?requirements down from the tool itself…)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be very annoying to manage:

  • the ?requirements (the argument needs to go up the stack very far, you would end-up with Gatk.indel_realigner that takes tons of overriding arguments: ?gatk_requirements, ?samtools_sort_requirements, ?samtools_index_requirements, ?merge_bams_requirements, etc. (installations, downloads, …)
  • and then it would have to go up the Pipeline_edsl API too

And on top of that it would break the clean-ish separation between bioinformatics and infrastructure. The goal is to be able to reuse 100% of the pipeline/Tools code unchanged, and switch between completely different Machine.ts at will.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another downside: if you have different invocations of the same tool, you can't configure them separately.

@ihodes
Copy link
Member

ihodes commented Apr 13, 2016

Tough to name this, but instead of ~self_ids, we could just have ~ids (as it is the ID of the make process), and the type in ~requirements could be ``Make_process_id`?

(I can file this as a separate issue)

@smondet smondet deleted the self-identify-requirement branch April 21, 2016 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ID specific to each tool/command which Machine.t can dispatch on
2 participants