Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing for commonly used callables #253

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

kalfa
Copy link

@kalfa kalfa commented Sep 25, 2024

Fix typing for raises() isinstance_of() and with_args(), to satisfy to mypy and pyright linting

@brunns
Copy link
Member

brunns commented Sep 26, 2024

Looks like you are missing some imports.

@kalfa
Copy link
Author

kalfa commented Sep 26, 2024

there you go, apologies.

I did the edit directly on github, and of course that was not a good choice ;-)

@kalfa
Copy link
Author

kalfa commented Sep 26, 2024

ok, something else failed.

It seems that those failures were the reasons raises was untyped?

Not sure I understand right now the problem, I will look into this later (but open to suggestions).

to help mypy/pyright linting
@kalfa
Copy link
Author

kalfa commented Sep 26, 2024

This is my first patch to the project, since I wanted to have test not continuously failing type checking.

I understand that those tests failing for 3.12 on various platform are advisory. they seem to underline linting problems that were there before.

@brunns
Copy link
Member

brunns commented Sep 26, 2024

FWIW, I can't get the lint target running locally. On the first run it reformats the code, and on a second run it objects to the code it's just changed.

@kalfa
Copy link
Author

kalfa commented Sep 26, 2024

yes, noticed that. I thought it was something I did with my local linters, and forced-pushed a basic change, but it was reapplied

@offbyone
Copy link
Member

I'm gonna be traveling the next couple of days, but I'll look into it.

I suppose we're coming up on the point where a minor release also makes sense. :D

@offbyone offbyone merged commit c356382 into hamcrest:main Sep 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants