Fix skip cache error (#732)

* Fix skip cache error * Delete token cache when failed to get email --------- Co-authored-by: 杨赫然 <[email protected]>
haiwen · Dec 30, 2024 · e2d7718 · e2d7718
1 parent ee9ad5e
commit e2d7718
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/fileserver/sync_api.go b/fileserver/sync_api.go
@@ -1287,13 +1287,15 @@ func validateToken(r *http.Request, repoID string, skipCache bool) (string, *app
 		}
 	}
 
-	if value, ok := tokenCache.Load(token); ok {
-		if info, ok := value.(*tokenInfo); ok {
-			if info.repoID != repoID {
-				msg := "Invalid token"
-				return "", &appError{nil, msg, http.StatusForbidden}
+	if !skipCache {
+		if value, ok := tokenCache.Load(token); ok {
+			if info, ok := value.(*tokenInfo); ok {
+				if info.repoID != repoID {
+					msg := "Invalid token"
+					return "", &appError{nil, msg, http.StatusForbidden}
+				}
+				return info.email, nil
 			}
-			return info.email, nil
 		}
 	}
 
@@ -1304,6 +1306,7 @@ func validateToken(r *http.Request, repoID string, skipCache bool) (string, *app
 		return email, &appError{err, "", http.StatusInternalServerError}
 	}
 	if email == "" {
+		tokenCache.Delete(token)
 		msg := fmt.Sprintf("Failed to get email by token %s", token)
 		return email, &appError{nil, msg, http.StatusForbidden}
 	}