Only set X-Forwarded-Proto when header not set #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espadrine
force-pushed
the
x-fwd-proto
branch
from
8ecd6b0 to
6a10685
Compare
When the seafile docker container
is behind a proxy that does the TLS termination,
such that the seafile docker sees HTTP only,
then, it receives requests
where the following headers are set in the following way:
X-Forwarded-Proto: https
X-Forwarded-Ssl: on
Because the default NGINX template has this directive:
proxy_set_header X-Forwarded-Proto $scheme
the request gets transmitted to gunicorn with the following,
contradictory values:
X-Forwarded-Proto: http
X-Forwarded-Ssl: on
Thus Seafile rejects the requests
with a "Contradictory scheme headers" error.
We instead change the header only when it is not set.
Fixes haiwen#226.
espadrine
force-pushed
the
x-fwd-proto
branch
from
6a10685 to
e65f1db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the seafile docker container
is behind a proxy that does the TLS termination,
such that the seafile docker sees HTTP only,
then, it receives requests
where the following headers are set in the following way:
Because the default NGINX template has this directive:
the request gets transmitted to gunicorn with the following, contradictory values:
Thus Seafile rejects the requests
with a "Contradictory scheme headers" error.
We instead change the header only when it is not set.
Fixes #226.