Add wait_for_memcached #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olof-nord
reviewed
Dec 7, 2021
| def wait_for_memcached(): | ||
| while True: | ||
| try: | ||
| with telnetlib.Telnet(host='memcached', port=11211, timeout=3) as tn: |
There was a problem hiding this comment.
Hello!
I came here to have a look at the memcached configuration options.
As far as I see it, there is no MEMCACHED_HOST environment variable, but I guess one day there might be one.
Making this MR future-proof, one could already now add it here.
As the default value would be used when no configuration is provided, I only see this as saving some work when adding the memcached config later.
host=get_conf('MEMCACHED_HOST', 'memcached')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the seafile container is started before the memcached container, some error message will be generated in seahub.log.
To avoid this situation, wait for memcached to start before seahub starts.