feat(core): remove error logging for missing aria attributes

haiilo · Jun 19, 2024 · a0bdf28 · a0bdf28
1 parent 9de1247
commit a0bdf28
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 101 deletions.
diff --git a/core/src/components/cat-avatar/cat-avatar.tsx b/core/src/components/cat-avatar/cat-avatar.tsx
@@ -1,5 +1,4 @@
 import { Component, h, Prop, State, Watch } from '@stencil/core';
-import { delayedAssertWarn } from '../../utils/assert';
 import loadImg from '../../utils/load-img';
 
 /**
@@ -69,10 +68,6 @@ export class CatAvatar {
     this.onSrcChanged(this.src);
   }
 
-  componentWillRender(): void {
-    delayedAssertWarn(this, () => !!this.label, '[A11y] Missing ARIA label on avatar');
-  }
-
   render() {
     if (this.url) {
       return (

diff --git a/core/src/components/cat-button/cat-button.tsx b/core/src/components/cat-button/cat-button.tsx
@@ -1,5 +1,4 @@
 import { Component, Event, EventEmitter, h, Listen, Method, Prop, State, Watch } from '@stencil/core';
-import { delayedAssertWarn } from '../../utils/assert';
 import { Breakpoint, Breakpoints, isBreakpoint } from '../../utils/breakpoints';
 import { MediaMatcher } from '../../utils/media-matcher';
 
@@ -184,10 +183,6 @@ export class CatButton {
     this.onIconOnlyChanged(this.iconOnly);
   }
 
-  componentWillRender(): void {
-    delayedAssertWarn(this, () => !this.isIconButton || !!this.a11yLabel, '[A11y] Missing ARIA label on icon button');
-  }
-
   @Listen('click')
   haltDisabledEvents(event: Event): void {
     if (this.disabled || this.loading) {

diff --git a/core/src/components/cat-checkbox/cat-checkbox.tsx b/core/src/components/cat-checkbox/cat-checkbox.tsx
@@ -1,5 +1,4 @@
 import { Component, Element, Event, EventEmitter, h, Host, Method, Prop, State } from '@stencil/core';
-import { delayedAssertWarn } from '../../utils/assert';
 import { CatFormHint } from '../cat-form-hint/cat-form-hint';
 
 let nextUniqueId = 0;
@@ -124,18 +123,6 @@ export class CatCheckbox {
     this.updateResolved();
   }
 
-  componentWillRender(): void {
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on checkbox'
-    );
-  }
-
   /**
    * Programmatically move focus to the checkbox. Use this method instead of
    * `input.focus()`.

diff --git a/core/src/components/cat-date-inline/cat-date-inline.tsx b/core/src/components/cat-date-inline/cat-date-inline.tsx
@@ -2,7 +2,6 @@ import { Component, Element, Event, EventEmitter, Host, Listen, Method, Prop, St
 import { catI18nRegistry as i18n } from '../cat-i18n/cat-i18n-registry';
 import { getLocale } from './cat-date-locale';
 import { addDays, addMonth, clampDate, isSameDay, isSameMonth, isSameYear } from './cat-date-math';
-import { delayedAssertWarn } from '../../utils/assert';
 import firstTabbable from '../../utils/first-tabbable';
 
 let nextUniqueId = 0;
@@ -127,18 +126,6 @@ export class CatDateInline {
     }
   }
 
-  componentWillRender(): void {
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on input'
-    );
-  }
-
   componentDidRender() {
     if (this.focusDate) {
       // re-focus the previously focused date after re-render

diff --git a/core/src/components/cat-input/cat-input.tsx b/core/src/components/cat-input/cat-input.tsx
@@ -1,7 +1,6 @@
 import { Component, Element, Event, EventEmitter, h, Method, Prop, State, Watch } from '@stencil/core';
 import Cleave from 'cleave.js';
 import type { CleaveOptions } from 'cleave.js/options';
-import { delayedAssertWarn } from '../../utils/assert';
 import { coerceBoolean, coerceNumber } from '../../utils/coerce';
 import { CatFormHint, ErrorMap } from '../cat-form-hint/cat-form-hint';
 import { catI18nRegistry as i18n } from '../cat-i18n/cat-i18n-registry';
@@ -209,15 +208,6 @@ export class CatInput {
 
   componentWillRender(): void {
     this.onErrorsChanged(this.errors);
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on input'
-    );
   }
 
   /**

diff --git a/core/src/components/cat-radio/cat-radio.tsx b/core/src/components/cat-radio/cat-radio.tsx
@@ -1,5 +1,4 @@
 import { Component, Element, Event, EventEmitter, h, Host, Method, Prop, State } from '@stencil/core';
-import { delayedAssertWarn } from '../../utils/assert';
 import { CatFormHint } from '../cat-form-hint/cat-form-hint';
 
 let nextUniqueId = 0;
@@ -103,18 +102,6 @@ export class CatRadio {
    */
   @Event() catBlur!: EventEmitter<FocusEvent>;
 
-  componentWillRender(): void {
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on radio'
-    );
-  }
-
   /**
    * Programmatically move focus to the radio button. Use this method instead of
    * `input.focus()`.

diff --git a/core/src/components/cat-select/cat-select.tsx b/core/src/components/cat-select/cat-select.tsx
@@ -18,7 +18,6 @@ import {
   tap,
   timer
 } from 'rxjs';
-import { delayedAssertWarn } from '../../utils/assert';
 import { coerceBoolean, coerceNumber } from '../../utils/coerce';
 import { CatFormHint, ErrorMap } from '../cat-form-hint/cat-form-hint';
 import { catI18nRegistry as i18n } from '../cat-i18n/cat-i18n-registry';
@@ -360,15 +359,6 @@ export class CatSelect {
 
   componentWillRender(): void {
     this.onErrorsChanged(this.errors);
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on select'
-    );
   }
 
   @Listen('blur')

diff --git a/core/src/components/cat-textarea/cat-textarea.tsx b/core/src/components/cat-textarea/cat-textarea.tsx
@@ -1,6 +1,5 @@
 import { Component, Element, Event, EventEmitter, h, Host, Method, Prop, State, Watch } from '@stencil/core';
 import autosize from 'autosize';
-import { delayedAssertWarn } from '../../utils/assert';
 import { coerceBoolean, coerceNumber } from '../../utils/coerce';
 import { CatFormHint, ErrorMap } from '../cat-form-hint/cat-form-hint';
 import { catI18nRegistry as i18n } from '../cat-i18n/cat-i18n-registry';
@@ -153,15 +152,6 @@ export class CatTextarea {
 
   componentWillRender(): void {
     this.onErrorsChanged(this.errors);
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on textarea'
-    );
   }
 
   componentDidLoad(): void {

diff --git a/core/src/components/cat-toggle/cat-toggle.tsx b/core/src/components/cat-toggle/cat-toggle.tsx
@@ -1,5 +1,4 @@
 import { Component, Element, Event, EventEmitter, h, Host, Method, Prop, State } from '@stencil/core';
-import { delayedAssertWarn } from '../../utils/assert';
 import { CatFormHint } from '../cat-form-hint/cat-form-hint';
 
 let nextUniqueId = 0;
@@ -120,18 +119,6 @@ export class CatToggle {
     this.updateResolved();
   }
 
-  componentWillRender(): void {
-    delayedAssertWarn(
-      this,
-      () => {
-        this.hasSlottedLabel = !!this.hostElement.querySelector('[slot="label"]');
-        this.hasSlottedHint = !!this.hostElement.querySelector('[slot="hint"]');
-        return !!this.label && !!this.hasSlottedLabel;
-      },
-      '[A11y] Missing ARIA label on toggle'
-    );
-  }
-
   /**
    * Programmatically move focus to the toggle. Use this method instead of
    * `input.focus()`.

diff --git a/core/src/utils/assert.ts b/core/src/utils/assert.ts