Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in feature/hafs.v2.0.1 back to develop #299

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from

Conversation

BinLiu-NOAA
Copy link
Collaborator

@BinLiu-NOAA BinLiu-NOAA commented Nov 1, 2024

Description of changes

Bring in the HAFSv2.0.1 development and configurations used by 2024 HFIP real-time parallel experiments back to HAFS develop branch. More details/configurations for 2024 HFIP HAFSv2.0.1A and B real-time parallel experiments can be found below.

  • HAFSv2.0.1A configurations
    • System and infrastructure
      • Synced HAFS submodules with their latest authoritative branches as of 07/03/2024
    • Vortex initialization and data assimilation upgrades
    • Physics and dynamics improvements
      • Adopt the scale-adaptive convective cloud water calculation in saSAS and reduce the minimum background diffusivity in the inversion layer near the PBL top from xkinv1=0.4 to xkinv1=0.15 (From Lisa Bengtsson, details can be found #2340)
      • Unify and turn on progsigma for saSAS for all the TC basins
      • Use the Exponential-Random (instead of Maximum-Random) cloud overlap approach (iovr=5) in RRTMG (AER/DTC/EMC)
      • Unify and use hord=1 with lim_fac of 3.0
    • Coupling
      • Use new RTOFSv2.5 input data
      • Use MOM6 ePBL mixed layer scheme with the OM4 related options (@MariaAristizabal-NOAA)
        • EPBL_MSTAR_SCHEME = "OM4"
  • HAFSv2.0.1B configurations
    • System and infrastructure
      • Synced HAFS submodules with their latest authoritative branches as of 07/03/2024
    • Vortex initialization and data assimilation upgrades
    • Physics and dynamics improvements
      • Use the new Tiedtke CP scheme with increased entrainment/detrainment coefficients (@AndrewHazelton)
      • Reduce elmx/rlmx from 75 to 60 (@AndrewHazelton)
      • Use hord=1 with lim_fac of 2.6
    • Coupling
      • Use new RTOFSv2.5 input data
      • Use MOM6 ePBL mixed layer scheme (@hyunsookkim-NOAA and @AndrewHazelton)
        • EPBL_MSTAR_SCHEME = "CONSTANT"
        • USE_PSURF_IN_EOS=True (instead of False)
        • EQN_OF_STATE = "JACKETT_06" (instead of WRIGHT)
        • FOX_KEMPER_ML_RESTRAT_COEF = 1.0 (instead of 0.0)
        • KAPPA_SHEAR_ITER_BUG = False (instead of True)

Issues addressed (optional)

If this PR addresses one or more issues, please provide link(s) to the issue(s) here.

Contributors (optional)

If others worked on this PR besides the author, please include their user names here (using @Mention if possible).
EMC hurricane project team with lots of collaborators from the UFS Hurricane Application Team.

Tests conducted

What testing has been conducted on the PR thus far? Describe the nature of any scientific or technical tests, including relevant details about the configuration(s) (e.g., cold versus warm start, number of cycles, forecast length, whether data assimilation was performed, etc). What platform(s) were used for testing?

Technical, retrospective, and real-time parallel testing were conducted.

Application-level regression test status

Running the HAFS application-level regression tests is currently performed by code reviewers after the developer creates the initial PR. As regression tests are conducted, the testers should use the checklist below to indicate successful regression tests. You may add other tests as needed. If a test fails, do not check the box. Instead, describe the failure in the PR comments, noting the platform where the test failed.

  • Jet
  • Hera
  • Orion
  • Hercules
  • WCOSS2

BinLiu-NOAA and others added 30 commits July 3, 2024 23:09
…tbl_new after the latest HAFS submodule syncing.
ush/hafs_filter_topo.sh, and ush/hafs_make_orog.sh. These updates are
needed with the latest hafs_utils.fd sync. Also, the filter_topo and
make_orog_gsl steps are substantialy speeded up through OMP threading.
HAFS.v2.0.1, due to issues associated with the new updated restart file
(sfc_data) with the latest UFS_UTILS chgres_cube updates. This is a
temporary solution. The longer term solution is to update hafs_datool,
VI, and GSI/DA so that they can work with the update restart files.
* Update parm/mom6/regional/hafs_mom6.input.IN needed for MOM6 update.
* Update scripts/exhafs_analysis.sh to link a new crtm fix file.
…dvars.conf, hafs.conf to improve the SLP and short range forecast. In convert_axi_xy.f90, the threshold for shallow composite vortex is changed from p_obs.lt.91510 (HAFS vortex SLP) to vslp.lt.92010 (TCVitals SLP)
@lisa-bengtsson's change to improve convection/radiation interaction.
Add parm/mom6/regional_hafs.v2.0.1a and parm/mom6/regional_hafs.v2.0.1b.
update parm/forecast/globnest/input*.nml.tmp according to its regional
counterpart.
…ability enabled.

* Update parm/ww3/regional/ww3_grid_?.inp by adding &OUTS USSP =1, IUSSP = 3, STK_WN = 0.04, 0.110, 0.3305 /
* Update parm/mom6/regional_hafs.v2.0.1a/hafs_mom6.input.IN with USE_WAVES = True
also set the moving nest d02 increments along the domain boundaries
(within 10 grid points) as zeros. (From @XuLu-NOAA and @BinLiu-NOAA)
Update parm/hafs.v2.0.1a.conf with lim_fac=2.7
@BinLiu-NOAA BinLiu-NOAA added the enhancement New feature or request label Nov 1, 2024
 - Updating run.ver for hafs and RTOFS versions.
 - Update scripts/exhafs_obs_prep.sh, which properly handles tempdrop
   obs processing errors/warnings.
@BinLiu-NOAA BinLiu-NOAA marked this pull request as ready for review November 9, 2024 17:26
@BinLiu-NOAA BinLiu-NOAA added Ready for Review The PR is considered complete by the author(s) Ready for RTs The PR is ready to conduct Regression Tests RTs Running on WCOSS2 Regression Tests are running on WCOSS2 labels Nov 9, 2024
@BinLiu-NOAA
Copy link
Collaborator Author

@JunghoonShin-NOAA, @nriveratorres-NOAA, @LinZhu-NOAA, @ChuankaiWang-NOAA, could you please help to cover the regression tests for this PR on the following platforms, respectively?
Jet: @JunghoonShin-NOAA
Orion: @nriveratorres-NOAA
Hercules: @ChuankaiWang-NOAA
Hera: @LinZhu-NOAA
WCOSS2: @BinLiu-NOAA

Thanks!

@BinLiu-NOAA BinLiu-NOAA self-assigned this Nov 14, 2024
@BinLiu-NOAA BinLiu-NOAA removed the RTs Running on WCOSS2 Regression Tests are running on WCOSS2 label Nov 14, 2024
@BinLiu-NOAA
Copy link
Collaborator Author

Regression tests on WCOSS2 have already passed successfully without issues.

@ChuankaiWang-NOAA
Copy link
Contributor

ChuankaiWang-NOAA commented Nov 18, 2024

Using batch instead of windfall to avoid queueing.
RT passed on Hercules.

@nriveratorres-NOAA
Copy link

Regression tests passed successfully on Orion

@JunghoonShin-NOAA
Copy link
Contributor

All regression tests completed successfully on Jet. But the ocean input data for the test case (2020 Laura 13L) does not exist on Jet anymore, and so I used Hurricane Lee as a test case.

@BijuThomas-NOAA
Copy link
Contributor

Since Lin is on travel, I conducted the RT on Hera. All regression tests were completed successfully on Hera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for Review The PR is considered complete by the author(s) Ready for RTs The PR is ready to conduct Regression Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring in HAFSv2.0.1 real-time parallel experiment related developments back to HAFS develop
8 participants