Silence complaints generated by mdnsd when legacy AirDrop is used on macOS #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: mdnsd/packet.c
…RR entries. modified: mdnsd/log.c
|
Ping? |
|
@haesbaert -- Could you let us know if you have abandoned this project? I'm still interested in seeing this PR, along with PR #35 and PR #38, merged and released such that the OpenBSD ports pick up the changes (and thence the FreeBSD ports) |
|
Hi,
Sorry, I did not abandon it, I'll have a look this weekend.
…On Fri, Oct 2, 2020, 19:41 Nick Briggs ***@***.***> wrote:
@haesbaert <https://github.com/haesbaert> -- Could you let us know if you
have abandoned this project? I'm still interested in seeing this PR, along
with PR #35 <#35> and PR #38
<#38>, merged and released such
that the OpenBSD ports pick up the changes (and thence the FreeBSD ports)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABR2EHYUOJUHHY7442DZXTSIYGDRANCNFSM4GHSTJKQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two minor changes stop mdnsd from logging errors for unknown RR types for the T_NULL (10) RR when a mac uses legacy AirDrop within range of an mdnsd's hearing.
Recognizing (and ignoring) the T_NULL RR will also allow any other RR entries in the received packet to be processed rather than aborting packet processing for an unrecognized type.