Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and specs with Rust types #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cleanup and specs with Rust types #3

wants to merge 3 commits into from

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Jun 12, 2023 •
edited
Loading

  • chacha20 spec with Rust types and export
  • sha256 spec with Rust types and export

Part of #13

karthikbhargavan
karthikbhargavan reviewed Jun 13, 2023
View reviewed changes
Copy link

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to see if we could use secret-integers as an external crate to get secret independence for this spec, replacing u32 with U32 etc. We could try that in a subsequent PR as well.

@W95Psp W95Psp mentioned this pull request Jun 14, 2023
Open
4 tasks
@franziskuskiefer
Copy link
Member Author

@W95Psp do you intend to look at this or shall I merge it?

@franziskuskiefer
Copy link
Member Author

Assigning you @karthikbhargavan, please merge when the lax typechechking is going through.

@franziskuskiefer franziskuskiefer mentioned this pull request Jan 3, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikbhargavan karthikbhargavan karthikbhargavan left review comments

@W95Psp W95Psp Awaiting requested review from W95Psp

At least 1 approving review is required to merge this pull request.

Assignees

@karthikbhargavan karthikbhargavan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franziskuskiefer @karthikbhargavan