Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore neg_equiv_lemma #1004

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

mamonet
Copy link
Collaborator

@mamonet mamonet commented Oct 16, 2024

This PR restores neg_equiv_lemma which is needed for portable compress proofs in this PR cryspen/libcrux#631.

Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't this lemma be two lemmas? 🤔
Also, can you add a definition in proof-libs/fstar/rust_primitives/Rust_primitives.Integers.fst? (a actual proof would be cool, but if that's taking too much time, put at least an let ... = admit ())

@mamonet
Copy link
Collaborator Author

mamonet commented Oct 16, 2024

Definition is already in proof-libs/fstar/rust_primitives/Rust_primitives.Integers.fst, some signatures were dropped while refactoring that module. I will check why it has no proof and see if it's easy to reason that lemma

@W95Psp
Copy link
Collaborator

W95Psp commented Oct 16, 2024

Ahh! Sorry I misunderstood! Sounds good to me!

@franziskuskiefer
Copy link
Member

@karthikbhargavan double check if this got merged already elsewhere.

@karthikbhargavan karthikbhargavan merged commit ec4703f into experiment-refined-ints Nov 28, 2024
10 of 13 checks passed
@karthikbhargavan karthikbhargavan deleted the refined-ints-neg branch November 28, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants