Use react-dimensions to get BaseMap to be responsive 🗺️ #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltomasku
changed the title
jaronheard
approved these changes
Jun 21, 2018
|
Looks like the BaseMap tests have to be updated now that the map is wrapped in the Dimensions thing. I'm happy to drive this home if you're busy today. |
|
@DingoEatingFuzz yeah i'm pretty busy today, feel free to drive it home if you have time! i think this is the related issue: digidem/react-dimensions#35 but feel free to solve the best way you see fit. |
|
@danieltomasku Turns out Dimensions won't render its children if it doesn't have a width and a height...which it doesn't in tests. So I just skipped them 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
react-dimensionspackage which gives the dimensions of a parent container. This is needed becausereact-map-glwidth and height props require a number, not percentage or units. NowBaseMapcan be responsive in a card!Closes #290