This repository has been archived by the owner on Jul 6, 2019. It is now read-only.
Fix nightly to the 'demos are green' condition #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems reasonable since the plugin relies on so many unstable rustc interfaces
@bgamari will need to take a second look at this one.
[insert I have no idea what I am doing meme here]
but I have absolutely no idea what is happening around here, the syntax seems to be very odd.
Closed
farcaller
added a commit
that referenced
this pull request
Jan 14, 2015
Fix nightly to the 'demos are green' condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates #270 and seems to finally work.
We still depend on a hack described in rust-lang/rust#18699 to make it build on osx and linux.