Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate setup.py to pyproject.toml #950

Merged
merged 11 commits into from
Oct 9, 2024

Conversation

DanielYang59
Copy link
Contributor

Summary

  • Migrate setup.py to pyproject.toml

@DanielYang59 DanielYang59 marked this pull request as ready for review October 7, 2024 05:41
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Matthew Evans <[email protected]>
Copy link
Collaborator

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ml-evs ml-evs merged commit ee5747d into hackingmaterials:main Oct 9, 2024
3 of 4 checks passed
@DanielYang59
Copy link
Contributor Author

No problem, thanks for reviewing and the new trick :)

@DanielYang59 DanielYang59 deleted the to-pyproject-toml branch October 10, 2024 02:03
DanielYang59 added a commit to DanielYang59/pymatviz that referenced this pull request Oct 10, 2024
janosh pushed a commit to janosh/pymatviz that referenced this pull request Oct 14, 2024
* reduce duplicate, new trick from hackingmaterials/matminer#950 (comment)

* reduce it further?

* add a comma for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants