Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable release creation workflow on forks #940

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

gbrunin
Copy link
Contributor

@gbrunin gbrunin commented Jul 29, 2024

I kept having this issue with our fork:
https://github.com/Matgenix/matminer/actions/runs/10141810059/job/28039988779

which I fixed by setting GITHUB_TOKEN and PAT explicitly. I'm not super familiar with the test.yml file so maybe there's a better fix (or maybe it should not be fixed), let me know.

* Explicit env variables settings.

* test

* Revert adding other branch to testing
@gbrunin
Copy link
Contributor Author

gbrunin commented Jul 29, 2024

Not sure why the 2 tests on datasets are failing with python 3.9

Copy link
Collaborator

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the test pypi build is failing, or why it is even triggering...

.github/workflows/test.yml Show resolved Hide resolved
Copy link
Collaborator

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other failures are unrelated, so happy to merge this now if it fixes things at your end @gbrunin.

@ml-evs ml-evs changed the title Explicit env variable setting for auto-gen-release Disable release creation workflow on forks Jul 30, 2024
@ml-evs ml-evs merged commit 761c99f into hackingmaterials:main Jul 30, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants