Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT REVIEW: testing CodeQL alert behavior #5577

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

roslynwythe
Copy link
Member

No issue

What changes did you make?

  • Added code to generate an alert, in lines 27-33 of _includes/about-page/about-card-sponsors.html

Why did you make the changes (we will use this info to test)?

  • I want to see how the alert is displayed to members of the website-write team vs. website-merge team and if members of website-write can dismiss the alert.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b roslynwythe-test-CodeQL2 gh-pages
git pull https://github.com/roslynwythe/website.git test-CodeQL2

@@ -24,6 +24,13 @@
<a href="https://www.sipandsonder.com" target="_blank" alt="Sip and Sonder">
<img src="/assets/images/sponsors/sip-sonder.svg" title="Sip and Sonder">
</a>
{% comment %}
{%for sponsor in site.data.internal.sponsors%}
<a href="{{sponsor.link}}" target="_blank" alt="{{sponsor.name}}" >

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@roslynwythe roslynwythe added Draft Issue is still in the process of being created Ignore: Test Issue was created for testing purposes only labels Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Draft Issue is still in the process of being created Ignore: Test Issue was created for testing purposes only
Projects
Status: PR Needs review
Development

Successfully merging this pull request may close these issues.

1 participant